Ticket #11142 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix unstable RemoveExpDecay test

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

RemoveExpDecayTest is failing frequently and randomly on the build servers. As well as generally being a bad thing™, it's getting annoying.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Refs #11142 Fix unstable RemoveExpDecay test

Changeset: efc0e9f540786a07087d7173d7e22b5623710631

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #264.

comment:5 Changed 6 years ago by Martyn Gigg

This is a great start but it would be great if all of the references to the AnalysisDataService are removed. They should not longer be necessary. The algorithms can be set as a child and then the output workspace can be retrieved with alg->getProperty("OutputWorkspace")

comment:6 Changed 6 years ago by Harry Jeffery

Refs #11142 Remove dependency on ADS

Changeset: 6d45da40a624c2e9d644bc7c492cf2e32907782b

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:8 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:9 Changed 6 years ago by Dan Nixon

There is a compile error on RHEL6.

comment:10 Changed 6 years ago by Harry Jeffery

Refs #11142 Fix compilation error

Changeset: 103ac646e7fd98d33adddd70ce184a3a1c6a50c4

comment:11 Changed 6 years ago by Martyn Gigg

Jenkins, retest this please.

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to verify
  • Tester Dan Nixon deleted

comment:12 Changed 6 years ago by Martyn Gigg

  • Tester changed from Dan Nixon to Martyn Gigg

comment:14 Changed 6 years ago by Martyn Gigg

The changes look good now, let's hope that it makes some difference.

comment:15 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to closed

Merge pull request #264 from mantidproject/11142_fix_unstable_removeexpdecay_test

Fix unstable RemoveExpDecay test

Full changeset: ​0cdb13d020b4e9d03954dcb5a9ac6b0f35959736

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11981

Note: See TracTickets for help on using tickets.