Ticket #11144 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Declare Python member variables in the class - scripts

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Python Keywords:
Cc: Blocked By:
Blocking: #11143 Tester: Andrei Savici

Description

Declare Python member variables in the class for Python files under the scripts directory.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Owner set to Dan Nixon

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Initial clean up of Python files in scripts

Refs #11144

Changeset: df8d3d84d40888190eb1714474bd76c0757845b2

comment:3 Changed 6 years ago by Dan Nixon

More refactoring of Python scripts

This has extended to final newlines, semicolons, indentation

Refs #11144

Changeset: a966d3b43f6f1ebb4d91115d1f54de8deca28ebb

comment:4 Changed 6 years ago by Dan Nixon

Refactor remaining scripts

Refs #11144

Changeset: efcd9887655f064dfa6c99d17c8132326e5c96f0

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #281.

comment:6 Changed 6 years ago by Dan Nixon

Fix broken unit test for direct reduction helper

Refs #11144

Changeset: 3d7c8c1232da30fb9e5b478efb377dd32a66b3fe

comment:7 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:8 Changed 6 years ago by Andrei Savici

  • Status changed from verify to closed
  • Tester set to Andrei Savici

Merge pull request #281 from mantidproject/11144_declare_python_members_scripts

Various PyLint fixes in scripts folder

Will keep an eye on systemtets

Full changeset: ​ca9c465470e00eb186894f1034a806c2d4522b34

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11983

Note: See TracTickets for help on using tickets.