Ticket #11148 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Declare Python member variables in the class - everywhere else

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Python Keywords:
Cc: Blocked By:
Blocking: #11143 Tester: Harry Jeffery

Description

Declare Python member variables in the class for Python files not covered by the other tickets.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Owner set to Dan Nixon
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Fix remaining member variable warnings

Refs #11148

Changeset: 8541357878aa3f7eaceee51cba83ae5a996e7c6a

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #301.

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:5 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11148_declare_python_members_everywhere_else

Refs #11148

Changeset: 9d3fd1d159bd8e1f15e6c76eac4b68866eae684f

comment:6 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:7 Changed 6 years ago by Harry Jeffery

PythonScriptsTest_DirectEnergyConversionTest is failing pretty consistently. Looks like it's actually broken, not just a random failure. Looking at the diff I've no idea how though.

comment:8 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11148_declare_python_members_everywhere_else

Refs #11148

Changeset: ca671a59d30dd0d70a1c07af7fb930c492bcb67d

comment:9 Changed 6 years ago by Dan Nixon

Undo changes to Direct Energy Conversion

Refs #11148

Changeset: b685ff428b18a1544784a3a5bd4e4d3c8c88e929

comment:10 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #301 from mantidproject/11148_declare_python_members_everywhere_else

Fix remaining PyLint member variable warnings

Full changeset: ​8e6579ea5f65346e0ce2cbe0f2be1418df58c3c0

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11987

Note: See TracTickets for help on using tickets.