Ticket #11149 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Modify failing OSIRIS fury fit test

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Dan Nixon) (diff)

It is going to take longer to investigate the issue here (#11150), in the mean time make the test pass by increasing the comparison tolerance on OSX.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Summary changed from Remove failing OSIRIS fury fit test to Modify failing OSIRIS fury fit test

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Up the workspace comparison tolerance on OSX

Refs #11149

Changeset: 8f04a860557ad508f34774c13b09d1a405c6d4f2

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #15.

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:7 Changed 6 years ago by Martyn Gigg

Unfortunately this is enough. It gets around all errors with the exception of one: ` CheckWorkspacesMatch-[Debug] Data mismatch at cell (hist#,bin#): (3,0) CheckWorkspacesMatch-[Debug] Dataset #1 (X,Y,E) = (0.189076,1.76644e-15,34692) CheckWorkspacesMatch-[Debug] Dataset #2 (X,Y,E) = (0.189076,9.73656e-16,0) CheckWorkspacesMatch-[Debug] Difference (X,Y,E) = (0,7.92786e-16,34692) CheckWorkspacesMatch-[Notice] The workspaces did not match: Data mismatch ` For some reason the error value in the *incorrect* dataset has a large value.

I think for now we are going to have to disable the test completely.

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #15 from mantidproject/11149_make_osiris_furyfit_test_pass_on_osx

Disable OSIRIS FuryFitMulti test on OSX

Full changeset: ​cc42070fff115f3357c641546e656d20cc22c76f

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11988

Note: See TracTickets for help on using tickets.