Ticket #11152 (closed: fixed)
Fix coverity issues in MantidPlot's Graph
| Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Dan Nixon |
Description (last modified by Federico M Pouzols) (diff)
Concerns coverity issues 1075783-830 (Graph.cpp).
Most if not all of these issues appear to be unchecked dynamic casts.
Change History
comment:3 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
dynamic_cast, scaleFonts(), coverity issue 1075830, re #11152
Changeset: cd98bb4ed174548024b05b81c8e127927b2c7dfc
comment:4 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, insrtCurve(), coverity issue 1075829, re #11152
Changeset: 98f1112253ccc989e0fa793052d376748337835c
comment:5 Changed 6 years ago by Federico Montesino Pouzols
dynamic_casts, marterCurve(), coverity issues 1075827,8, re #11152
Changeset: 777ff68fffb4a91ec9ca174a77dfd3cc76bea1d8
comment:6 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, removeCurve(), coverity issue 1075826, re #11152
Changeset: 1aecabcfa4e696b7e1b0fa2ff5b984bad9211c71
comment:7 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, removeCurves(), coverity issue 1075822, re #11152
Changeset: 866ad1773bbd3f641db55dd5314cf02fd7d3caf0
comment:8 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setGrayScale(), coverity issues 1075819-21, re #11152
Changeset: 93dd0f18a1e8be2bf24c1d490ef66214cabbf90e
comment:9 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, niceLogScales(), coverity issue 1075818-21, re #11152
Changeset: f24be58d84cce8846a51536f1a6a8d339f58eb0e
comment:10 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, axisFormatInfo(), coverity issue 1075817, re #11152
Changeset: aeb335a9d4c851d82b9ad16c36aae58831cd3739
comment:11 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, deselectCurves(), coverity issue 1075816, re #11152
Changeset: b97348c3f9327056ca5c350e6c956f9815bd4307
comment:12 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setCurrentFont(), coverity issue 1075815, re #11152
Changeset: 12a4cfad4259e4280d1afed31e9c9999b2be4597
comment:13 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, deselectMarker(), coverity issue 1075814, re #11152
Changeset: 745fad99db4a323228c516b97a52aaa823d59f99
comment:14 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, saveCurveLayout(), coverity issues 1075811-13, re #11152
Changeset: 53e92d1231a13b8ea80fbdea89f497933336eda6
comment:15 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setIndexedColors(), coverity issue 1075810, re #11152
Changeset: ab44e13ceef14f1984292f058c3401154945b819
comment:16 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setMajorTicksType(), coverity issue 1075809, re #11152
Changeset: e95ab9ec262cb026fe3f88871748c04a507c30ea
comment:17 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setIndexedColors(), coverity issue 1075808, re #11152
Changeset: 9c1a9b52413f6869151dc10dd6dcb638b6d638e2
comment:18 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, updateImageMarker(), coverity issue 1075807, re #11152
Changeset: 65800d25f5f8b57cc9601957efb150513702180a
comment:19 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setSelectedMarker(), coverity issue 1075806, re #11152
Changeset: 1116453c04b3ecf980e5929f993ad530345ff93d
comment:20 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, savePieCurveLayout(), coverity issue 1075805, re #11152
Changeset: 9bdd2525ebde83aacc4c5b16304756c09e04e57d
comment:21 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, updateSecondaryAxis(), issues 1075799,800,803, re #11152
Changeset: 27a4b6e9010108c9085c7a82b5fa648bd284690f
comment:22 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, selectedCurveLabels(), issue 1075802, re #11152
Changeset: 0d626530ef5d40b1724c828295b6de93b16a3437
comment:23 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, setAxisTicksLength(), coverity issue 1075801, re #11152
Changeset: 02c0f8360172b5a9c8bd0709d3fab9e8c9853238
comment:24 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, guessUniqueCurveLayout(), cvrty issue 1075797, re #11152
Changeset: 3d721aca502cc725cc193fda321be6ff3c6af9a3
comment:25 Changed 6 years ago by Federico Montesino Pouzols
dynamic_casts, copy(), coverity issues 1075790-96,98, re #11152
Changeset: 6d8efcb41d97a9cef79c516847259019a1a2b2b5
comment:26 Changed 6 years ago by Federico Montesino Pouzols
dynamic_casts, axistype(), coverity issue 1075789, re #11152
Changeset: a8d647b7c95d07856d62ce9520b664c1fcfb7694
comment:27 Changed 6 years ago by Federico Montesino Pouzols
dynamic_casts, setScale(), coverity issue 1075786,88, re #11152
Changeset: f769b73b457e62e4f41a9014997ef0401e11cf7a
comment:28 Changed 6 years ago by Federico Montesino Pouzols
dynamic_casts, showAxis(), coverity issue 1075785, re #11152
Changeset: 0ff0f9e71d77a668678e5e2bc5000b6a1d6930cc
comment:29 Changed 6 years ago by Federico Montesino Pouzols
dynamic_cast, removePie(), coverity issue 1075783, re #11152
Changeset: 653dd8467ae8bf33fa3aead582d03a789258acfc
comment:30 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #289.
comment:31 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:32 Changed 6 years ago by Dan Nixon
Did not see any obvious issues in code review and had a quick test of graph manipulation within MantidPlot.
comment:33 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge pull request #289 from mantidproject/11152_fix_coverity_issues_MantidPlot_Graph
Fix coverity issues in MantidPlot's Graph
Full changeset: f512b50f2ede4222afb94bad18318f598d3e52ab
comment:34 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:35 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11991
