Ticket #11154 (closed: fixed)
Fix systemtests failing because of pylint warnings
| Reported by: | Andrei Savici | Owned by: | Andrei Savici |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.4 |
| Component: | Python | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Ross Whitfield |
Description
Due to changes in ticket #11134, there are a few systemtests that fail. http://builds.mantidproject.org/view/Wall%20display/job/master_systemtests/313/
Change History
comment:2 Changed 6 years ago by Andrei Savici
- Status changed from assigned to inprogress
Undo some changes that broke systemtests. Refs #11154
I accidentally deleted the content of ConjoinFiles algorithm. It was not picked up by the unittests since there is none for this algorithm. The sns_command_interface has a lot of unused imports. But those are passed on to be used in the systemtests.
Changeset: e80b891afa24212f31db2b971567dd95223510fb
comment:3 Changed 6 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #274.
comment:4 Changed 6 years ago by Andrei Savici
To test:
- code review: The Conjoin files should be similar to what it was before. And sns_command_interface should just have lines uncommented
- Systemtests should pass. The REFM reduction on RHEL6 failed before these changes
comment:5 Changed 6 years ago by Ross Whitfield
- Status changed from verify to verifying
- Tester set to Ross Whitfield
comment:6 Changed 6 years ago by Ross Whitfield
- Status changed from verifying to closed
Merge pull request #274 from mantidproject/11154_pylintFixesThatBrokeSystemtests
Undo some pylint changes that broke systemtests.
Full changeset: 1fa16a3736b238fe84ae910f3f9a8cc8cb264710
