Ticket #11170 (closed: fixed)
EnginXCalibrateTest fails on osx 10.9
| Reported by: | Steven Hahn | Owned by: | Steven Hahn |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
On the osx 10.9 build, self.zero find a slightly different value of self.zero
Traceback (most recent call last):
File "<string>", line 1, in <module> File "/Users/svh/Documents/MantidProject/systemtests/StressTestFramework/stresstesting.py", line 347, in returnValidationCode
if self.doValidation():
File "/Users/svh/Documents/MantidProject/systemtests/StressTestFramework/stresstesting.py", line 317, in doValidation
validation = self.validate()
File "/Users/svh/Documents/MantidProject/systemtests/SystemTests/AnalysisTests/EnginXCalibrateTest.py", line 25, in validate
self.assertDelta(self.zero, 3.53, 0.01)
File "/Users/svh/Documents/MantidProject/systemtests/StressTestFramework/stresstesting.py", line 391, in assertDelta
raise Exception(msg)
Exception: Expected 3.51142 == 3.53 within +- 0.01.
Change History
comment:2 Changed 6 years ago by Steven Hahn
Refs #11170. Allow slightly different value of self.zero on 10.9 build.
Changeset: ef67f0a387e54e412495f139dd91ada3214d6970
comment:3 Changed 6 years ago by Steven Hahn
- Status changed from new to verify
- Resolution set to fixed
This is being verified as pull request #17.
comment:4 Changed 6 years ago by Steven Hahn
Refs #11170. Add accidentally deleted line.
Changeset: 36fa18286de7b0c0a8e5bded2772c10e25fe7971
comment:5 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:6 Changed 6 years ago by Martyn Gigg
Agreed we need this until we understand the differences in fitting on OS X.
comment:7 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #17 from mantidproject/11170_fix_EnginXCalibrateTest
Fix EnginXCalibrateTest on OS X 10.9
Full changeset: 1591acadb70b4b4bcab989421f692d219ef1b961
comment:9 Changed 6 years ago by Steven Hahn
- Status changed from closed to verify
This is being verified as pull request #18.
comment:11 Changed 6 years ago by Martyn Gigg
This looks like it should now cover all cases that we have seen.
comment:12 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #18 from mantidproject/11170_increase_tolerance
Fix EnginXCalibrateTest on OS X 10.9 (again)
Full changeset: e361f30220aa7ed5c5ada8d299bdbc3f8e35677f
comment:13 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12009
This looks very similar to other issues with fitting on os x (see, for example http://trac.mantidproject.org/mantid/ticket/10328). Until we find the root cause, the best option is to accept the slightly different result.