Ticket #11174 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Create1DWorkspaceConstant does not create the correct values

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

The function WorkspaceCreationHelper::Create1DWorkspaceConstant has two parameters, value and error. Instead of assigning value to y-values of the created workspace and error to the error-values, it assigns error to both. I would like to fix this problem. Since this helper is used in some unit tests, these have to be checked whether modification is required.

Change History

comment:1 Changed 6 years ago by Michael Wedel

  • Status changed from new to inprogress

Refs #11174. Added failing test case and fix problem.

Changeset: 23b9dd22ff17d9d2c60fa6da9a680518a6b62833

comment:2 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #473.

comment:3 Changed 6 years ago by Michael Wedel

Refs #11174. Adding small tolerance to test

PolarizationCorrectionTest failed, because the error on the output workspace of the algorithm is 2.2e-16 instead of 0.0. I could not find out why, so I added a small tolerance to the unit test.

Changeset: 5b7b69a216d4efdda4e07f85e5a22301a3ed1205

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #473 from mantidproject/11174_fix_create_1d_workspace_constant

Fix Create1DWorkspaceConstant

Full changeset: c030001ba5d3338c251fcc4374a630a8441cc35c

comment:6 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12013

Note: See TracTickets for help on using tickets.