CheckWorkspacesMatch ignores tolerance when checking numeric axis

[Dan Nixon]

And is causing the systemtests to fail on OS X 10.9.

[Dan Nixon]

Implement equal to tolerance function in NumericAxis

and use in CheckWorkspacesMatch

Refs #11179

Changeset: 9016870764518b6e472e5145e3a0c772124cdbd2

[Dan Nixon]

Unit test changes to NumericAxis

Refs #11179

Changeset: d2f9d86da0a6ca062b43aaf4572bafae644d26a5

[Dan Nixon]

This is being verified as ​pull request #309.

[Dan Nixon]

Jenkins, retest this please.

[Dan Nixon]

Jenkins, retest this please.

[Dan Nixon]

Jenkins, retest this please.

[Steven Hahn]

1) Would you please add unit tests for the special case when one or more of the values is Inf or NaN?

2) I think this should replace the current behavior of virtual bool operator==(const Axis &) const because we should never use operator== to compare floating point values. Can we create an optional argument for the tolerance?

3) Consider replacing your for loop with std::equal and a binary predicate.

4) The system test is still failing on os x because m_values.size() is not equal. 

[Dan Nixon]

Test inf and NaN use std::equal

Refs #11179

Changeset: 180b6e76d38de56206eea2b04b7b4005f6a7c971

[Dan Nixon]

1. Done.
2. operator== can only take a single parameter as the other reference, I agree that it should probably use a tolerance through (1e-15?).
3. Done
4. This ticket was just to fix the issue with CheckWorkspacesMatch, I'm still looking at what's wrong with the OSX.

[Dan Nixon]

operator== should use tolerance by default

Refs #11179

Changeset: 916e91c6819857b79ed85e46225a292e36517b73

[Steven Hahn]

There is an error on Windows.

3) Would you replace your global variable and function with a functor? 4) Agreed, that shouldn't stop it from being merged into master.

[Dan Nixon]

Use functor for equality with tolerance check

Refs #11179

Changeset: 65a6bace12b0e9d9dd98cb01e29ca9252f7d3047

[Dan Nixon]

Correct NaN and infinity comparison

Refs #11179

Changeset: 3573429bddae777131b38a664ee09bfb9014f1d5

[Dan Nixon]

Not checking with the tolerance provided would pretty much defeat the point of this ticket, and removing the first if would make the test pass as the values would never be checked.

[Steven Hahn]

retest this please

[Steven Hahn]

Yes, using the provided tolerance would be better.

Running ISISIndirectAnalysisTest on master, CheckWorkspacesMatch is false because of the equality comparison between NumericAxis. In this branch, it fails because of the equality comparison between RefAxis.

[Steven Hahn]

The win7 build has the following error. I'm going to try retesting. ` 18:14:29 ISISLiveEventDataListener-[Error] Caught a runtime exception. 18:14:29 ISISLiveEventDataListener-[Error] Exception message: Operation of receiving Events header timed out. `

[Steven Hahn]

retest this please

[Dan Nixon]

Fix RefAxis comparison in CheckWorkspacesMatch

Refs #11179

Changeset: 0ab23ddbfee6b612ba715703ed5f3d6205534cde

[Dan Nixon]

Jenkins, retest this please.

[Steven Hahn]

retest this please

[Dan Nixon]

Decalre equalWithinTolerance virtual

Refs #11179

Changeset: 4486d7ca8a0bd00ab5998ae4419954ecf28050c9

[Dan Nixon]

Remove default tolerance in equalWithinTolerance

Refs #11179

Changeset: 5bbd613b479016329c93075ed6eb1765309d1a56

[Steven Hahn]

retest this please

[Steven Hahn]

I tested this last week and found it fixed the issues comparing those two workspaces. The new changes made today look good and it's passing all tests on jenkins. Let's :shipit:

[Steven Hahn]

Merge pull request #309 from mantidproject/11179_checkworkspacesmatch_use_tolerance_on_numericaxis

CheckWorkspacesMatch should use tolerance property on NumericAxis comparison

Full changeset: ​128ea4abccdb6ea0fc3c722c5924a823737f2c78

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​12018