Ticket #11182 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improve usability of EstimatePDDetectorResolution

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: zhouw@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

The algorithm is a bit hard to use and isn't connected to documentation the way it should be. Amongst the issues:

  • It validates the input parameters on exec rather than in init
  • It should be mentioned in CalibrateRectangularDetectors and GetDetOffsetMultiPeaks as well as link to them
  • Make it work with a "metadata only" workspace
  • Allow the user to supply the cetre wavelength

Change History

comment:1 Changed 6 years ago by Peter Peterson

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Peterson

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Pete Peterson

Re #11182. Moving code from header to source

Changeset: 5a3c8625f98a7be9ab448827501738c10d6e4d1d

comment:4 Changed 6 years ago by Pete Peterson

Re #11182. deltaTOF is required to be positive

Changeset: 71d8f2f0d0ed978809240c58ee39d8c7fdab9d8d

comment:5 Changed 6 years ago by Pete Peterson

Re #11182. Renaming to PDEstimateDetectorResolution

Changeset: 61384f856f193b88382e119410144f1ff31dd66f

comment:6 Changed 6 years ago by Pete Peterson

Re #11182. Added cross links to rst docs.

Changeset: 48c03baa28cf53e0fe07bf79916d6208d7b22967

comment:7 Changed 6 years ago by Pete Peterson

Re #11182. clang-format the test

Changeset: 9928625c5d1ba6a551455d3a967dbf1b56106e2a

comment:8 Changed 6 years ago by Pete Peterson

Re #11182. Refactored code for readability

Changeset: 6e4e730151853f71d1b45a6b7cd354318c146418

comment:9 Changed 6 years ago by Pete Peterson

Re #11182. Added optional parameter for wavelength

Changeset: afb0edfe6929a7956fd1a6449fdc209b70687b41

comment:10 Changed 6 years ago by Pete Peterson

Re #11182. Fixed bug in metadataonly loading

It wasn't adding spectra to the workspace.

Changeset: de98088d5a1d5ce0d73a568aba818f44fa32a6b7

comment:11 Changed 6 years ago by Pete Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #320.

comment:12 Changed 6 years ago by Pete Peterson

Re #11182. Changed theta calculation.

Since the workspace has it, just use its.

Changeset: ea47b8666e40a011575c4c7d476a3d216e401dd8

comment:13 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:14 Changed 6 years ago by Pete Peterson

Re #11182. Deleteted too much code before.

Changeset: 6f99d3641df1b7e838ea8f3ae61f40ac86e48da1

comment:16 Changed 6 years ago by Pete Peterson

Re #11182. Fixed bug in wavelength to velocity conversion

Changeset: 50f8936c73672853242abe8aba60b90c6ebba8c2

comment:17 Changed 6 years ago by Wenduo Zhou

The new features work fine. The ticket is to be closed.

But the documentation of LoadEventNexus should be modified because the behavior of loading meta data only is changed, i.e., the number of spectra in output workspace is change.

comment:18 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge pull request #320 from mantidproject/11182_EstimatePDDeterminResolution_improvements

PDEstimateDetectorResolution improvements

Full changeset: ​ad3fa44be338b68b448d4da9a3f60c75cc19d9f3

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12021

Note: See TracTickets for help on using tickets.