Ticket #11183 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CurveFitting dependency in APITest breaks valgrind build

Reported by: Martyn Gigg Owned by: Michael Wedel
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

In #11104 PeakFunctionIntegrator was moved to API. Unfortunately the unit test uses the Gaussian function defined in CurveFitting.

This breaks the valgrind core packages Jenkins job that only builds up to DataObjects and needs to be able to run without any plugins.

Some kind of mock or fake peak will have to be used in PeakFunctionIntegratorTest to avoid this. You should also be able to remove the call to FrameworkManager::Instance() in the constructor of the test, which should reproduce the problem locally for you.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Michael Wedel

  • Status changed from assigned to inprogress

Refs #11183. Replacing factory-Gaussian with local implementation.

Changeset: c8156cbed75684e9c3c907b53b211574d02272e9

comment:3 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #310.

comment:4 Changed 6 years ago by Michael Wedel

Jenkins retest this please

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico M Pouzols

All tests pass and there seem to be no plugin dependinces left.

comment:7 Changed 6 years ago by Michael Wedel

Refs #11183. Replacing factory-Gaussian with local implementation.

Changeset: c8156cbed75684e9c3c907b53b211574d02272e9

comment:8 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #310 from mantidproject/11183_remove_curvefitting_dependency_from_apitest

Remove CurveFitting dependency from PeakFunctionIntegratorTest

Full changeset: ​c469932094142000bc9113450d9bd3ffec6801a4

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12022

Note: See TracTickets for help on using tickets.