Ticket #11219 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix broken systemtest caused by FunctionParameterDecorator

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.4
Component: Framework Keywords: Fitting
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The default implementation of FunctionParameterDecorator::nParams() was a bit too strict in throwing an exception if no function is actually decorated, causing the CodeConventions system test to fail with this message: 

for i in xrange(function.numParams()):
RuntimeError: No wrapped function set, aborting.

Returning 0 in case of no function being decorated will solve this issue.

Change History

comment:1 Changed 6 years ago by Michael Wedel

  • Status changed from new to inprogress

Refs #11219. Changing implementation of nParams and nAttributes

These methods now return 0 instead of throwing when no function is decorated.

Changeset: 8826549c5075ea36d497518e3d934402911583d0

comment:2 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #343.

comment:3 Changed 6 years ago by Michael Wedel

Jenkins retest this please

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 6 years ago by Martyn Gigg

Jenkins, retest this please

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #343 from mantidproject/11219_fix_function_parameter_decorator

Fix broken systemtest caused by FunctionParameterDecorator

Full changeset: ​beb67d62b0b7c48b4359aebed372c431ffc3b605

comment:7 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12058

Note: See TracTickets for help on using tickets.