Ticket #11244 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Output from SCDCalibratePanels is hard to work with

Reported by: Martyn Gigg Owned by: Vickie Lynch
Priority: critical Milestone: Release 3.4
Component: Diffraction Keywords: 2015 ssc sns
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Leighton Coates has more details.

Attachments

MANDI_801.peaks (19.1 KB) - added by Vickie Lynch 6 years ago.
MANDI_801.mat (564 bytes) - added by Vickie Lynch 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Priority changed from major to critical

Batch modify all SSC tickets to critical priority (this will also show up as an update for all those already as critical)

comment:2 Changed 6 years ago by Nick Draper

  • Owner changed from Nick Draper to Owen Arnold
  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

  • Owner changed from Owen Arnold to Vickie Lynch

comment:4 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to inprogress

Refs #11244 fix xml output file

Changeset: 6a4a96735b4bd5faf05c5e77d27a02b6e72704d5

comment:5 Changed 6 years ago by anonymous

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #455.

comment:6 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

Changed 6 years ago by Vickie Lynch

Changed 6 years ago by Vickie Lynch

comment:7 Changed 6 years ago by Vickie Lynch

Use empty instrument for Mandi file:

LoadIsawPeaks(Filename='MANDI_801.peaks', OutputWorkspace='peaks')
SCDCalibratePanels(PeakWorkspace='peaks',DetCalFilename='mandi_801.DetCal',XmlFilename='mandi_801.xml',a=74,b=74.5,c=99.9,alpha=90,beta=90,gamma=60)
LoadEmptyInstrument(Filename='/home/vel/Mantid/Code/Mantid/instrument/MANDI_Definition_2013_08_01.xml', OutputWorkspace='MANDI_801_event')
CloneWorkspace(InputWorkspace='MANDI_801_event', OutputWorkspace='MANDI_801_event_xml')
LoadParameterFile(Workspace='MANDI_801_event_xml', Filename='mandi_801.xml')
RenameWorkspace(InputWorkspace='MANDI_801_event_xml', OutputWorkspace='MANDI_801_event_DetCal')
LoadIsawDetCal(InputWorkspace='MANDI_801_event_DetCal', Filename='mandi_801.DetCal')

comment:8 Changed 6 years ago by Federico Montesino Pouzols

comment:9 Changed 6 years ago by Federico Montesino Pouzols

All looks good, this seems to fix the issue and the modified test script posted on the trac issue worked well for me locally (tested on debian).

For the future it would be great if the example script included in the .rst file is turned into a doc-test, so we protect this functionality. For that doc-test the modified/simplified version posted on trac is probably better/faster, as it only uses the two small .peaks and .mat files.

comment:10 Changed 6 years ago by Federico Montesino Pouzols

Merge pull request #455 from mantidproject/11244_output_calibrate_scd

Refs #11244 fix xml output file

Changeset: 3964efd3f34f912ca067caff8791bbd6992cdb32

comment:11 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #455 from mantidproject/11244_output_calibrate_scd

Refs #11244 fix xml output file

Full changeset: 3964efd3f34f912ca067caff8791bbd6992cdb32

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12083

Note: See TracTickets for help on using tickets.