Ticket #11256 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IntegratePeaksMD slower this release for TOPAZ

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Pete Peterson

Description

Two theta and phi for all the detectors should be calculated once and saved for using in detectorQ for all peaks.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

  • Status changed from new to inprogress

Refs #11256 calculate E1 for each detector once

Changeset: d0bafdce17cd2dab807c591999c8eee5b8fce44a

comment:2 Changed 6 years ago by anonymous

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #349.

comment:3 Changed 6 years ago by anonymous

Test with file from systemtests: Load(Filename='TOPAZ_3132_event.nxs', OutputWorkspace='TOPAZ_3132_event', LoadMonitors=True) ConvertToMD(InputWorkspace='TOPAZ_3132_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', LorentzCorrection=True, OutputWorkspace='TOPAZ_3132_md', MinValues='-25,-25,-25', MaxValues='25,25,25', SplitInto='2', SplitThreshold=50, MaxRecursionDepth=13, MinRecursionDepth=7) FindPeaksMD(InputWorkspace='TOPAZ_3132_md', PeakDistanceThreshold=0.37680000000000002, MaxPeaks=50, DensityThresholdFactor=100, OutputWorkspace='TOPAZ_3132_peaks') FindUBUsingFFT(PeaksWorkspace='TOPAZ_3132_peaks', MinD=3, MaxD=15, Tolerance=0.12) CopySample(InputWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False) IndexPeaks(PeaksWorkspace='TOPAZ_3132_peaks', Tolerance=0.12) ShowPossibleCells(PeaksWorkspace='TOPAZ_3132_peaks') SelectCellWithForm(PeaksWorkspace='TOPAZ_3132_peaks', FormNumber=32, Apply=True) CopySample(InputWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False) ConvertToMD(InputWorkspace='TOPAZ_3132_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', OutputWorkspace='MantidEVWorker_sphere_integrate_temp_MD_ws', MinValues='-30,-30,-30', MaxValues='30,30,30', SplitInto='2,2,2', SplitThreshold=200, MaxRecursionDepth=10, MinRecursionDepth=7) IntegratePeaksMD(InputWorkspace='MantidEVWorker_sphere_integrate_temp_MD_ws', PeakRadius=0.17999999999999999, BackgroundInnerRadius=0.17999999999999999, BackgroundOuterRadius=0.23000000000000001, PeaksWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_peaks', CylinderLength=0.40000000000000002, PercentBackground=20)

comment:4 Changed 6 years ago by Vickie Lynch

Refs #11256 edge calculation working for not in place

Changeset: 6c47bc39a8592058dc0fff9fc63af771c1db192a

comment:5 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:6 Changed 6 years ago by Vickie Lynch

Refs #11256 calculate E1 for each detector once

Changeset: d0bafdce17cd2dab807c591999c8eee5b8fce44a

comment:7 Changed 6 years ago by Vickie Lynch

Refs #11256 edge calculation working for not in place

Changeset: 6c47bc39a8592058dc0fff9fc63af771c1db192a

comment:8 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #349 from mantidproject/11256_faster_IntegratePeaksMD

Caching the values makes this way faster.

Full changeset: ​5f1f4a1fcd64d6dff35479ccb69649236196137b

comment:9 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12095

Note: See TracTickets for help on using tickets.