Ticket #11264 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

New algorithm to calculate DIFC for an instrument

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Ross Whitfield

Description

This will be used as part of the backbone for a next generation calibration of instruments. It should take an instrument geometry and (optionally) offsets workspace and return a new workspace with the y-values being the DIFC for every pixel.

Change History

comment:1 Changed 6 years ago by Pete Peterson

  • Status changed from new to inprogress

Re #11264. Adding generated algorithm stubs.

Changeset: 3559a47953289d28033c37243ea6ff85427222b3

comment:2 Changed 6 years ago by Pete Peterson

Re #11264. Implemented calculation of DIFC.

Changeset: 91c9cc5bef5d1a3d5fa1af450f7c038623fd6c7b

comment:3 Changed 6 years ago by Pete Peterson

Re #11264. Added unit tests.

Changeset: 0987b2adb428ed3a789670ea4454ed200d75995a

comment:4 Changed 6 years ago by Pete Peterson

Re #11264. Filled in user documentation.

Changeset: 023bd1116879b7e9b57e03ace8f5272abbdc9fb7

comment:5 Changed 6 years ago by Pete Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #366.

comment:6 Changed 6 years ago by Ross Whitfield

  • Status changed from verify to verifying
  • Tester set to Ross Whitfield

comment:7 Changed 6 years ago by Pete Peterson

Re #11264. Fixing issues in unit test.

Changeset: 7eb2479b4a1693ab8f44239ce76e274d0aa83cf0

comment:8 Changed 6 years ago by Pete Peterson

The failed windows build is related to the StartLiveData -> FakeISISEventDAE usage documentation test. Completely unrelated to this algorithm.

comment:9 Changed 6 years ago by Pete Peterson

Re #11264. Changing docs to use constants rather than numbers

Changeset: f7499f19279eaf92da13665f4bf8742e4fb8eb45

comment:10 Changed 6 years ago by Pete Peterson

Re #11264. Changed to SpecialWorkspace2D for performance.

Changeset: 3ab8974cb7fdefcc1d6d705964b1d1f0276f6a76

comment:11 Changed 6 years ago by Pete Peterson

Re #11264. Changed expected values in usage test

It is because the output workspace was changed to SpecialWorkspace2D.

Changeset: 5ed3dad5683d833faded3e84ed0e08cdcc51118a

comment:12 Changed 6 years ago by Ross Whitfield

  • Status changed from verifying to closed

Merge pull request #366 from mantidproject/11264_calculate_difc

New algorithm to calculate DIFC for an instrument

Full changeset: 40e5686e2dfb955e29bce57dc991eba86297a9f3

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12103

Note: See TracTickets for help on using tickets.