Ticket #11290 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Segfault when you view "Sample Material..." from MDWorkspace.

Reported by: Ross Whitfield Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

To reproduce: 

Load('CNCS_7860', OutputWorkspace='CNCS_7860_event')
ConvertToMD(InputWorkspace='CNCS_7860_event', QDimensions='Q3D', dEAnalysisMode='Elastic', OutputWorkspace='md')

Right click on "md" and select "Sample Material..."

It segfaults on 

void MantidSampleMaterialDialog::updateMaterial() {
MatrixWorkspace_sptr ws = AnalysisDataService::Instance().retrieveWS<MatrixWorkspace>(m_wsName.toStdString());

in MantidPlot/src/Mantid/MantidSampleMaterialDialog.cpp

Change History

comment:1 Changed 6 years ago by Andrei Savici

  • Status changed from new to assigned
  • Owner set to Dan Nixon

comment:2 Changed 6 years ago by Andrei Savici

You cannot cast an MD workspace to a MatrixWorkspace

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Don't show sample material diaglog for MD workspaces

Refs #11290

Changeset: c9681cd586f4c4e1fa1aa0fd5c3863b1bec55f1e

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #394.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #394 from mantidproject/11290_ssample_material_ui_md_segfault

Don't show sample material dialog for MD workspaces

Full changeset: ​480ec17449b7d13cd63a5c5cdde08453ca1f9ca8

comment:7 Changed 6 years ago by Peter Parker

Merge branch '11290_ssample_material_ui_md_segfault' of github.com:mantidproject/mantid into 11360_merge_robs_larmor_changes

Full changeset: ​d0cd60e2b554799702e8cb4d4ce49ad25a2bc785

comment:8 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12129

Note: See TracTickets for help on using tickets.