Ticket #11294 (closed: fixed)
add -Wextra on OSX build
| Reported by: | Steven Hahn | Owned by: | Steven Hahn |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #10839 | Tester: | Pete Peterson |
Description
Start work on ticket #10839 by adding the -Wextra flag to the OSX build and fixing/suppressing all warnings that occur.
Change History
comment:2 Changed 6 years ago by Steven Hahn
- Status changed from new to inprogress
Refs #11294. Added -Wextra flag and fixed all warnings.
Changeset: 6ed3fe8c6fa8c8131caff3924c2bd327a575e886
comment:3 Changed 6 years ago by Steven Hahn
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #371.
comment:4 Changed 6 years ago by Steven Hahn
"-Winit-self -Wpointer-arith -Wcast-qual -fno-common" was also added since they are present in GNUsetup.cmake and don't introduce any new warnings.
comment:5 Changed 6 years ago by Steven Hahn
Refs #11294. Add flags that don't generate warnings. clang-format
Changeset: 797ae94789d5582b113039084e6b8fd7e1f94df3
comment:8 Changed 6 years ago by Pete Peterson
- Status changed from verify to verifying
- Tester set to Pete Peterson
comment:9 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/11294_add_Wextra_clang'
Full changeset: ed39e8a378dc01c29a20273382cd23521605b02c
comment:10 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12133
The MDBoxSplit class is not included in CMakeLists.txt and when added doesn't build. I'm going to remove it as well as the one location when the header file is included.