Ticket #11306 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IAlgorithm::validateInputs not exposed in python or used

Reported by: Owen Arnold Owned by: Martyn Gigg
Priority: major Milestone: Release 3.4
Component: Python Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

We are now suggesting that people writing python algorithms can override validateInputs for validation of inputs purposes. Doing this in python will currently not have the desired effect.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to inprogress

Add validateInputs export for Python api

This should never need to be called but just in case... Refs #11306

Changeset: 2eff9f468cfe55e812ca8af689827706026ccfb4

comment:2 Changed 6 years ago by Martyn Gigg

Add a unit test for validateInputs behaviour from Python.

Refs #11306

Changeset: 067b949faab73d13fefd6aacd4f8fef297c2f29d

comment:3 Changed 6 years ago by Martyn Gigg

Remove requirement for test to write to disk

This should help with eliminating random failures when running the tests in parallel. Refs #11306

Changeset: 99bca82fda275792f1ceb18d44151909cde8e630

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #414.

comment:5 Changed 6 years ago by Martyn Gigg

Jenkins, retest this please

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #414 from mantidproject/11306_simpleapi_run_validate_inputs

Test for running validateInputs in Python

Full changeset: ​a67b0431ba91de3bbfc1bd510c1b3f26ce0383d4

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12145

Note: See TracTickets for help on using tickets.