Ticket #1131 (closed: wontfix)

Opened 11 years ago

Last modified 5 years ago

Fix bugs in LoadSNSNexus

Reported by: Nick Draper Owned by: Michael Reuter
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

The following bugs have been noted:

  • The monitor data is wrong (this might be the Nexus datatype is incorrect in the reader)
  • The monitor shape is not in the Nexus file (the reader is assuming sphere)
  • Allow Partial loading of detectors
  • The instrument tree is not being created sensibly.
  • The geometry of the instrument is close but appears to be scaled incorrectly in the y axis leading to overlaps of banks.

Change History

comment:1 Changed 10 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Stuart Campbell

(In [4490]) Load Monitor data using correct data type. Read correct distance for detectors. refs #1131

comment:3 Changed 10 years ago by Stuart Campbell

(In [4491]) Revert back to reading distance for entire bank for now. refs #1131

comment:4 Changed 10 years ago by Peter Peterson

(In [4586]) Making crappy code accessible to others. Nick will be unhappy. Refs #1131.

comment:5 Changed 10 years ago by Peter Peterson

(In [4589]) Version of the test that actually runs even though it doesn't check much. Refs #1131.

comment:6 Changed 10 years ago by Peter Peterson

(In [4591]) Lots of print statements, but fixed the direction of the indices in the block read. Refs #1131.

comment:7 Changed 10 years ago by Janik Zikovsky

(In [4606]) Disabled test of LoadSNSNexusTest.h, refs#1131

comment:8 Changed 10 years ago by Michael Reuter

(In [4663]) Fixed loading data for SNS NeXus files. Unit test reflects the ability to read the data. The test is still disabled since it takes 5 seconds to run. This refs #1131.

comment:9 Changed 10 years ago by Michael Reuter

  • Owner changed from Stuart Campbell to Michael Reuter

comment:10 Changed 10 years ago by Michael Reuter

(In [4705]) Added a missing type case for attributes. This helps more recent NeXus files read. This refs #1131.

comment:11 Changed 10 years ago by Michael Reuter

  • Milestone changed from Iteration 24 to Iteration 25

comment:12 Changed 10 years ago by Michael Reuter

  • Component set to Mantid
  • Milestone changed from Iteration 25 to Iteration 26

comment:13 Changed 10 years ago by Michael Reuter

  • Milestone changed from Iteration 26 to Iteration 27

comment:14 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:15 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:16 Changed 9 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to wontfix

Since this algorithm is obsolete, not being used and will be superseded, I'm closing this ticket as wontfix. The ticket to mark it as deprecated is #3227.

comment:17 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:18 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

Not deprecated yet, but the ticket is in place for the action to occur, there is no point doing further development on an algorithm we will not be keeping.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1979

Note: See TracTickets for help on using tickets.