Ticket #1133 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Mac build needs to move to GCC 4.1+ and be 64 bit

Reported by: Nick Draper Owned by: Russell Taylor
Priority: critical Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

At the moment the mac build is done on GCC 4.0, which means no openmp multithreading is going on. We originally encountered a few problems with newer versions of gcc on the Mac. However now the mac build is working it is time to revisit this.

Change History

comment:1 Changed 11 years ago by Russell Taylor

See #1139 for more info on this. Note that gcc 4.4+ will be needed because there's a bug in 4.1-4.3 that prevents compilation (it reports an 'internal compiler error').

comment:2 Changed 10 years ago by Stuart Campbell

  • Status changed from new to accepted

Looking into using Macports to get a newer gcc

comment:3 Changed 10 years ago by Stuart Campbell

  • Milestone changed from Iteration 24 to Iteration 25

comment:4 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to assigned

comment:5 Changed 10 years ago by Stuart Campbell

  • Owner changed from Stuart Campbell to Russell Taylor
  • Component set to Mantid

comment:6 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:7 Changed 10 years ago by Russell Taylor

  • Priority changed from minor to critical

comment:8 Changed 10 years ago by Russell Taylor

  • Status changed from assigned to accepted
  • Summary changed from Mac build needs to move to GCC 4.1+ to Mac build needs to move to GCC 4.1+ and be 64 bit

comment:9 Changed 10 years ago by Russell Taylor

(In [9087]) Handle the fact that Apple decided to put the OpenGL headers in a different place to everyone else. (This was originally handled on the Mac build server by just copying the headers into Third_Party. I am suitably ashamed of this.) Re #1133.

comment:10 Changed 10 years ago by Russell Taylor

(In [9089]) On Windows, windows.h must be included before OpenGL headers. Re #1133.

comment:11 Changed 10 years ago by Russell Taylor

(In [9116]) Switch includes in InstrumentWindow files from native to Qt OpenGL include, which takes care of the Mac location internally. Re #1133.

comment:12 Changed 10 years ago by Russell Taylor

(In [9120]) Changes to enable Mac build of Framework. Re #1133.

comment:13 Changed 10 years ago by Russell Taylor

(In [9121]) Change to top level CMakeLists for Mac. Re #1133.

comment:14 Changed 10 years ago by Russell Taylor

(In [9131]) Mods for Mac build. Re #1133.

comment:15 Changed 10 years ago by Russell Taylor

(In [9133]) Add nexus library for Mac to Third_Party. Re #1133.

comment:16 Changed 10 years ago by Russell Taylor

Everything now builds using CMake with gcc 4.0 on ismac (the Mac buildserver at ISIS) and all the unit tests pass. The one caveat is that it finds the 'wrong' python (2.6) so the cache has to be edited manually to change it back to 2.5.

Upgrading gcc version and the bit-ness (probably on Snow Leopard) will follow later....

comment:17 Changed 10 years ago by Russell Taylor

  • Milestone changed from Iteration 27 to Iteration 28

comment:18 Changed 10 years ago by Janik Zikovsky

(In [9619]) Refs #1133: Atom.cpp class modified to use a map instead of a lot of const atoms.

comment:19 Changed 10 years ago by Russell Taylor

(In [9622]) Undo changes to Atom.cpp, at least for now to get all builds working. Re #1133.

comment:20 Changed 10 years ago by Russell Taylor

(In [9646]) On the Mac, turn off optimization of Atom.cpp. Re #1133.

comment:21 Changed 10 years ago by Russell Taylor

(In [9939]) Minor modifications for mac64 build. Re #1133.

comment:22 Changed 10 years ago by Russell Taylor

(In [9962]) Remove spurious includes. May help mac build. Re #1133.

comment:23 Changed 10 years ago by Russell Taylor

(In [10064]) Improve error reporting. Re #1133.

comment:24 Changed 10 years ago by Russell Taylor

(In [10084]) For mac64 build. Re #1133.

comment:25 Changed 10 years ago by Russell Taylor

(In [10150]) Eliminate variation according to order of function argument evaluation in MonteCarloAbsorption. Nothing wrong with the code per se, but it made the test fail with the Intel compiler. Re #1133.

comment:26 Changed 10 years ago by Russell Taylor

(In [10183]) Last set of required changes to framework code to make 64 bit Mac build happy. Turns out that the Intel compiler really doesn't like 'continue' statements within catch clauses within openmp'd blocks. Re #1133.

comment:27 Changed 10 years ago by Russell Taylor

(In [10227]) Fix MedianDetectorTestTest seg fault caused by yesterday's changes to critical blocks. Re #1133.

comment:28 Changed 10 years ago by Russell Taylor

(In [10322]) CMake build file changes for Mac - 32 bit builds are no longer supported. Re #1133.

comment:29 Changed 10 years ago by Russell Taylor

(In [10413]) For now, hack existing Mac Installer to work with CMake build. Re #1133.

comment:30 Changed 10 years ago by Russell Taylor

(In [10415]) More Mac installer updates. Re #1133.

comment:31 Changed 10 years ago by Russell Taylor

(In [10439]) More installer updates. Re #1133.

comment:32 Changed 10 years ago by Russell Taylor

(In [10467]) Change name of mac installer file. Re #1133.

comment:33 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Done

comment:34 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:35 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Mac builds work (when the Intel compiler license is valid, at least :) )

comment:36 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1981

Note: See TracTickets for help on using tickets.