Ticket #11337 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LineViewer option not to overwrite line cuts

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.4
Component: GUI Keywords: VATES-vis
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

Line Plot should have an option beneath to specify that you do not want to overwrite existing line cuts. Requested by T Perring.

  • Default to off
  • Inspect the ADS to see if the cut exists
  • Increment an ending numeric value on the name unit a unique name is found

Probably best done by Owen Arnold.

1/2 man days work.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Owner changed from Anyone to Owen Arnold
  • Status changed from new to assigned
  • Component changed from Framework to User Interface
  • Milestone changed from Backlog to Release 3.4

comment:2 Changed 6 years ago by Nick Draper

  • Keywords VATES-vis added; VATES removed

comment:3 Changed 6 years ago by Owen Arnold

Test instructions

# Create md workspace
ws = CreateMDWorkspace(Dimensions=3, Extents='-10,10,-10,10,-10,10', Names='A,B,C', Units='U,U,U')
# Add some data so that we can see what we are doing
FakeMDEventData(InputWorkspace=ws, PeakParams='100000,-5,-5,0,1')
# Add some data so that we can see what we are doing
FakeMDEventData(InputWorkspace=ws, PeakParams='100000,5,5,0,1')

1) Default behaviour

  • Open ws in the SliceViewer
  • Open the line viewer mode by hitting the pencil icon
  • The 'Overwrite line' option should be checked
  • Now draw a line in the line viewer mode
  • A workspace called ws_line should be shown in the workspace list when you are done
  • Hit the X button to delete the line
  • Draw another line
  • Notice that the ws_line originally created has been overwritten you your new line.

2) Now repeat the process above but have the Overwrite option set OFF.

  • New line workspaces should be created as ws_line{n} where n is an integer.
Last edited 6 years ago by Owen Arnold (previous) (diff)

comment:4 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #11337. Option not to rename

Changeset: 44d9fab784290696c3e57e253d455c6151df6de7

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #510.

comment:6 Changed 6 years ago by Owen Arnold

jenkins retest this please

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

Tested and looks good. But in future could you put the clang reformatting into a separate commit from any code changes please? Having them in the same commit makes it far more difficult to perform a code review as it's unclear where the real changes actually are in the diff.

Just waiting on build results.

comment:9 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #510 from mantidproject/11337_line_renaming

Do not overwrite line cuts

Full changeset: 79a006916674c5eba7f965799a33b6676101d1b8

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12176

Note: See TracTickets for help on using tickets.