Ticket #11349 (closed)

Opened 6 years ago

Last modified 5 years ago

Propagate file extension property thorugh runDescriptors

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.4
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Anders-Markvardsen

Description

At the moment, RunDescriptor sets up default file extension once at initialization.

This file extension is used later to select incorrect file, if user actually wants to use different default file extension for the following runs.

Change History

comment:1 Changed 6 years ago by Alex Buts

  • Status changed from new to inprogress

Re #11349 Function which return default file extension in any case

when explicit file extension is not defined

Changeset: a1ec9962408d9a4d92852bde6a0cfb7c534fc95b

comment:2 Changed 6 years ago by Alex Buts

Re #11349 This should fix it.

Correctly specified default file extension and unit test for it.

Changeset: 8d4da5f1d1cf366052cfc388a83dad5b14579bb2

comment:3 Changed 6 years ago by Alex Buts

Re #11349 Unit test to ensure that string in brackets is processed

correctly

Changeset: 40c23ca6a22b70448510bf6b5d0d15359cd5ded8

comment:4 Changed 6 years ago by Alex Buts

This should be fixed as pull request ​https://github.com/mantidproject/mantid/pull/391

comment:5 Changed 6 years ago by Alex Buts

Re #11349 Minor changes to disable extension in a file list

and kick rebuild which seems fails due to the wrong settings.

Changeset: bb664818484e863adee41d917baffc135466ead3

comment:6 Changed 6 years ago by Alex Buts

Re #11349 Trying to identify some oddities observed on OSX and Ubunu

Changeset: 1406c7bf9ce18de81784e6bf1d8d1e227409c947

comment:7 Changed 6 years ago by Alex Buts

Re #11349 Attempt to identify reason for the OS specific failure

Changeset: 63491d9835c7439e0c5e8461ced8db050b3813d4

comment:8 Changed 6 years ago by Alex Buts

Re #11349 Should fix problem with different OS

(missing guess found)

Changeset: edb7dfd2664b1e8a73f9c0a916ca015c6ddd77d3

comment:9 Changed 6 years ago by Alex Buts

Re #11349 A trivial comment missing

Changeset: 266b50389dee78787e59d2d063222039f00ade0c

comment:10 Changed 6 years ago by Alex Buts

This is fixed as pull request ​https://github.com/mantidproject/mantid/pull/391

comment:11 Changed 6 years ago by Anders-Markvardsen

  • Status changed from inprogress to closed
  • Tester set to Anders-Markvardsen

Merge pull request #391 from mantidproject/11349_useDefaultFileExtension

Bugfix for correct default file extension in ISIS direct reduction

Full changeset: ​e80ec75853cf33fbc012061eaaab80ffcbeefc1a

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12188

Note: See TracTickets for help on using tickets.