Ticket #11355 (closed: fixed)
Port CutMD to C++
| Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | VATES-cli |
| Cc: | anton.piccardo-selg@… | Blocked By: | #11354 |
| Blocking: | Tester: | Owen Arnold |
Description
Make the python algorithm CutMD into a c++ data processing algorithm. Should be simple enough to port, and that way we can use it in the VSI.
For taking 3D visual cuts, Toby etc, will not want to have to use BinMD, SliceMD
Change History
comment:4 Changed 6 years ago by Harry Jeffery
Refs #11355 Remove python CutMD implementation
Changeset: 1a3db118db39e5925d66c2f8a4bce23d49fa599f
comment:5 Changed 6 years ago by Harry Jeffery
Refs #11355 Add C++ CutMD stub
Changeset: 099fb4a9feef267384e5166aa0979960935fad37
comment:6 Changed 6 years ago by Harry Jeffery
Refs #11355 Declare properties
Changeset: 8888e698cfb188590c01bb059e18458686e7fad6
comment:7 Changed 6 years ago by Harry Jeffery
Refs #11355 Port getDimensionExtents
Changeset: 8167eb86cd87edd5a94ecab2a6132f03e01d790b
comment:8 Changed 6 years ago by Harry Jeffery
Refs #11355 Port matrixFromProjection
Changeset: f7b27ccc4b672401423d17cb94926c87b8c4d4f2
comment:9 Changed 6 years ago by Harry Jeffery
Refs #11355 Port unitsFromProjection
Changeset: 853b021e164da7317877a0ff8c09f018e91470c1
comment:10 Changed 6 years ago by Harry Jeffery
Refs #11355 Port scaleProjection
Changeset: ab71f1000263744026a96b90b75c2f17f8f0b6df
comment:11 Changed 6 years ago by Harry Jeffery
Refs #11355 Port calculateExtents
Changeset: a1feebdfab05d8a97820f1bd8c189dbb5be2f793
comment:12 Changed 6 years ago by Harry Jeffery
Refs #11355 Use DblMatrix
Changeset: 9ac1325aa8498593c679b0e2d102bd91cf816db7
comment:13 Changed 6 years ago by Harry Jeffery
Refs #11355 Simplify types using typedef MinMax
Changeset: 697b96104618280154a29b5906a0b4bbae201a2d
comment:14 Changed 6 years ago by Harry Jeffery
Refs #11355 Increase const correctness
Changeset: 7768203660987f5eee03a5e4bb135eefc30d6d3b
comment:15 Changed 6 years ago by Harry Jeffery
Refs #11355 Port calculateSteps
Changeset: 2ead2c6ac8bfa5a206355901f3bbe4aaea05cfb8
comment:16 Changed 6 years ago by Harry Jeffery
Refs #11355 Port labelProjection
Changeset: 0a516acbb4c394b1184426499b680b9ad5cae9d2
comment:17 Changed 6 years ago by Harry Jeffery
Refs #11355 Remove unused property
CheckAxes isn't actually used in the original Python CutMD.
Changeset: c1296c223903a3c74dc0e2fdf4892c909e38a8c7
comment:18 Changed 6 years ago by Harry Jeffery
Refs #11355 Use a 2D vector instead of Matrix<string>
This avoids a runtime dynamic linking error.
Changeset: bf5de1fa65ab2333f3cc5f879365357df02a0c67
comment:19 Changed 6 years ago by Harry Jeffery
Refs #11355 ClangFormat
Changeset: 3de21286a661d141ce12a4e664383ef4447cd4b7
comment:20 Changed 6 years ago by Harry Jeffery
Refs #11355 Implement CutMD::execute()
Changeset: 4b3c2c4d41597b65268bb21d1be52a9c7f3fae8c
comment:21 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix bug in calculateExtents
Changeset: bf0a70233b76f3bd4f69614161307251b8b895ca
comment:22 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix crash in calculateSteps
Changeset: e07e0a07517bcb01134451670c856ce9bc26d326
comment:23 Changed 6 years ago by Harry Jeffery
Refs #11355 Remove debugging warnings
Changeset: 8e375e8cbf1f3c246200d5d96554b8da984d03d0
comment:24 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix "OutputBins" type
Changeset: 5405fd9345a1d13ec6d8123ae063205170652f15
comment:25 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix experimentinfo casting
Changeset: 35b25e6574e1896717a9ddf47613a3cc2b1afbee
comment:26 Changed 6 years ago by Harry Jeffery
Revert "Refs #11355 Remove unused property"
This reverts commit cded4ac9b33dcd79e0132e94de175a98ce81992f.
Changeset: 895ccaf0768c27f0e80f26853bee94bdc1e79e6f
comment:27 Changed 6 years ago by Harry Jeffery
Refs #11355 Re-introduce CutMD's python unit test
Changeset: bccedde26c3b07e8ac0d84bf68997080c56ebef2
comment:28 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix input table format test
Changeset: 0cc809ec1be912be22b84ed280d3a3b94279e3e0
comment:29 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix SliceMD output workspace
Changeset: 046f0ae3e74c5559170f9866760b57d2126bf3ee
comment:30 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix label output for CutMD test
Changeset: 2ca33063a38e7dff6887ede24245138f86d7f05a
comment:31 Changed 6 years ago by Harry Jeffery
Refs #11355 Tidy up label creation logic
Changeset: 0d6786f5c4470398703346fdea960f8da841f1af
comment:32 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix error in calculateSteps
Changeset: 58c70885a90a43ea82e55baaa24b9c8ee356bef0
comment:33 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix stepsize calculation for additional dimensions
Changeset: 9ff0c83f0ad716270e1a47a0cfd24d3f2cf875c0
comment:34 Changed 6 years ago by Harry Jeffery
Refs #11355 Add stub CutMD C++ test
Changeset: 56c1cc330b7466daed42ae9724179641ad8e81ad
comment:35 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer 4th bin param test
Changeset: 4eafac6b94cd32dcb7db0c6255bf66d7c8cc1d03
comment:36 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer slice to original test
Changeset: c1ee90c3d34f0cf573259b401f1fc4b5bc3aac78
comment:37 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer recalc extents test
Changeset: 1574effec75ae7fe1e6217b6f72cb7a5e23624e1
comment:38 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer truncate extents test
Changeset: 189d97f7906b4856fb10a6992f868ad7c3257db3
comment:39 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer projection columns test
Changeset: 4fc953044a8b0e686c85ce200076bc283e07149c
comment:40 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer projection rows test
Changeset: c55a64d97883217db3e46738435690cf19bf7ecd
comment:41 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer orthogonal slice with scaling test
Changeset: 6228c1f3bf734b2619a37ad99baef31d1a36d9f8
comment:42 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer non orthogonal slice test
Changeset: ef4316c847e4b4d001a755f5e045003d89e3878a
comment:43 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer orthogonal slice with cropping test
Changeset: 6b5a17a69f08f584f864ca6a5bac25eadc44b764
comment:44 Changed 6 years ago by Harry Jeffery
Refs #11355 Transfer orthogonal slice 4d test
Changeset: 74373e191a0f6b99cf7d864ae8e5f1411a932040
comment:45 Changed 6 years ago by Harry Jeffery
Refs #11355 Remove disused python unit test
Changeset: b89aa8cd9d029dda395708db62f4fc84170fcd9e
comment:46 Changed 6 years ago by Harry Jeffery
Refs #11355 Make projection table checking saner
The actual order of the columns doesn't matter, so don't require an arbitrary order.
Changeset: b155db6fd4e3e8ffc9184c65cfdab020f6e30e90
comment:47 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #488.
comment:49 Changed 6 years ago by Harry Jeffery
Refs #11355 Fix segfault when passing invalid projection
Changeset: 07706d89d711d1b45dc67a91941901c2f2d4bcc4
comment:50 Changed 6 years ago by Harry Jeffery
Jenkins, retest this please.
comment:51 Changed 6 years ago by Harry Jeffery
Tester: The only failure is SystemTests.ISISDirectInelastic.MERLINReduction which is unrelated and happening for many builds currently.
comment:52 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:53 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge pull request #488 from mantidproject/11355_port_cutmd_to_cpp
Port CutMD to C++
Full changeset: 3f9e470ea02d6ae84b471b8d4bc75bd5b186b831
comment:54 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:55 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12194
