Ticket #11384 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Use EstimatePeakErrors in PoldiFitPeaks2D

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords: POLDI
Cc: Blocked By: #11105
Blocking: Tester: Federico Montesino Pouzols

Description

In ticket #11105, a new algorithm EstimatePeakErrors has been introduced. Using this in PoldiFitPeaks2D will make the code dealing with errors much easier, so I would like to refactor the Poldi algorithm accordingly.

Change History

comment:1 Changed 6 years ago by Michael Wedel

  • Status changed from new to inprogress

Refs #11384. First additions.

Changeset: 628d84b4132761ac56a8e369967a92b80235b2e2

comment:2 Changed 6 years ago by Michael Wedel

Refs #11384. Changing signature, adding test for errors.

Changeset: 56044d5729ddc5b0a1bfba6043c85b367ea7fe00

comment:3 Changed 6 years ago by Michael Wedel

Refs #11384. Replace old error code with EstimatePeakErrors

Changeset: 962d3f0c5bd0fdcc0f1934842e8d75102f4ca80b

comment:4 Changed 6 years ago by Michael Wedel

Refs #11384. Extract covariance matrix assignment into method.

Changeset: 82e0ee3a0fe8288125bf80b71908f4d7dd759bf9

comment:5 Changed 6 years ago by Michael Wedel

Refs #11384. Fix offset error

Changeset: 43a836e4ec19dfa0d36ee9d8986db56dc77b9659

comment:6 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #475.

comment:7 Changed 6 years ago by Michael Wedel

Jenkins retest this please

comment:8 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:9 Changed 6 years ago by Federico Montesino Pouzols

All the Poldi/POLDI unit/system tests passed on the CI servers and also locally. Code changes look good, documented and tested.

comment:10 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #475 from mantidproject/11384_use_estimate_peak_errors_in_poldi_2d_fir

Refactor PoldiFitPeaks2D to use EstimatePeakErrors

Full changeset: ​2cf6eda22c2a87b19d3e5151fe1842445a1c6f30

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12223

Note: See TracTickets for help on using tickets.