Ticket #11392 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Move current content of remote algorithms and RemoteJobManager into Framework/RemoteJobManagers/MantidWebServiceAPIJobManager

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By: #11123, #11124
Blocking: #9277, #11126 Tester: Roman Tolchenov

Description (last modified by Federico M Pouzols) (diff)

The functionality related to remote job control for the Mantid Web Service API needs to be ready in a IRemoteJobManager class which could be MantidWebServiceAPIJobManager for when we can use the RemoteJobManagerFactory in the remote algorithms (#11126). This functionality is now spread through the class RemoteJobManager and the (~10) current Remote Algorithms (also including SimpleJSON). But note that these should not be removed as part of this ticket. That would happen around #11126.

There should be a MantidWebServiceAPIJobManagerTest unit test.

This ticket is a sibling of #11064 which includes/implies moving most of SCARFTomoReconstruction into Framework/RemoteJobManagers/.

The unit test RemoteJobManagerFactoryTest (introduced in #11124) should also be updated to test creation of this MantidWebServiceAPIJobManager type of job manager.

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:2 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:4 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

add new files for Mantid API in cmake lists, re #11392

Changeset: 55717fbd4cb08d96e98645f12c95549569641761

comment:5 Changed 6 years ago by Federico Montesino Pouzols

add job manager with helper and tests, re #11392

Changeset: 650bb386d9854ec5c5334a26d658cb3ecba5871c

comment:6 Changed 6 years ago by Federico Montesino Pouzols

add test files, re #11392

Changeset: 74fba2c6c48dfcaa3cf436ab80c2cfccc1ec84cd

comment:7 Changed 6 years ago by Federico Montesino Pouzols

extremely minimal test for the Mantid API helper, re #11392

Changeset: 5a75600b2bbd2f53e454013a1edea0ce1acb7745

comment:8 Changed 6 years ago by Federico Montesino Pouzols

queryAllRemoteJobs method in, and several fixes, re #11392

Changeset: 039e675dc45333f2f07531f55b246af2ddec3b54

comment:9 Changed 6 years ago by Federico Montesino Pouzols

adjust constness, methods doc, and added the last methods, re #11392

Changeset: bb15baf1be0e63dd8beabc6443cf5a868f4d13b9

comment:10 Changed 6 years ago by Federico Montesino Pouzols

more test cases, re #11392

Changeset: 96adfe67098fc3faa639cdb730c135585d06c6a4

comment:11 Changed 6 years ago by Federico Montesino Pouzols

prefer TSM_ asserts, UNUSED_ARGS out, rename TestJM->FakeJM, re #11392

Changeset: 6cb85cf2f402be818f2af4e8e75085f7eb1674f8

comment:12 Changed 6 years ago by Federico Montesino Pouzols

improvmts in WS API test, new protected hooks for testing, re #11392

Changeset: 7ee54f282e126c387dbfa7242d49dd5d93a005b5

comment:13 Changed 6 years ago by Federico Montesino Pouzols

TODO comment for hard-coded url, it's in another ticket, re #11392

Changeset: 4f43fecd088d590d19499063ddf1fcb3ac1dff0d

comment:14 Changed 6 years ago by Federico Montesino Pouzols

add another ticket's number in comment to keep track of it, re #11392

Changeset: d4ad309948202adf66c0463cf2a7287b02deebf1

comment:15 Changed 6 years ago by Federico Montesino Pouzols

add tests for ok and err codes with and without err message, re #11392

Changeset: 9f621645c1da37d83eaf9cd34e48ac24b2be6241

comment:16 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #521.

comment:17 Changed 6 years ago by Federico Montesino Pouzols

fix static members init, re #11392

Changeset: 076525074d1444f24298532ca5c6901b04f78ad5

comment:18 Changed 6 years ago by Federico Montesino Pouzols

proper fix for test static data members, re #11392

Changeset: 325f15f44b854dec43d208f7b790ae8f58912e3a

comment:19 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:20 Changed 6 years ago by Roman Tolchenov

Merge conflicts need to be resolved.

comment:21 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/master' into 11392_create_MantidWebServiceAPIJobManage_from_RemoteAlgorithms_andRemoteJobManager

Conflicts:

Code/Mantid/Framework/API/inc/MantidAPI/RemoteJobManagerFactory.h Code/Mantid/Framework/API/test/RemoteJobManagerFactoryTest.h Code/Mantid/Framework/RemoteJobManagers/CMakeLists.txt

Sort out conflict in CMakeLists (files added in another PR, #503) and factory test, re #11392

Changeset: 847613dd82b4ca76c98603ff3918f8a7eb0d1840

comment:22 Changed 6 years ago by Federico Montesino Pouzols

fix messed up test names after merge, re #11392

Changeset: 710eaf2c679f5e3143f63abdfda9862efe0a5fe2

comment:23 Changed 6 years ago by Federico Montesino Pouzols

add new files for Mantid API in cmake lists, re #11392

Changeset: 55717fbd4cb08d96e98645f12c95549569641761

comment:24 Changed 6 years ago by Federico Montesino Pouzols

add job manager with helper and tests, re #11392

Changeset: 650bb386d9854ec5c5334a26d658cb3ecba5871c

comment:25 Changed 6 years ago by Federico Montesino Pouzols

add test files, re #11392

Changeset: 74fba2c6c48dfcaa3cf436ab80c2cfccc1ec84cd

comment:26 Changed 6 years ago by Federico Montesino Pouzols

extremely minimal test for the Mantid API helper, re #11392

Changeset: 5a75600b2bbd2f53e454013a1edea0ce1acb7745

comment:27 Changed 6 years ago by Federico Montesino Pouzols

queryAllRemoteJobs method in, and several fixes, re #11392

Changeset: 039e675dc45333f2f07531f55b246af2ddec3b54

comment:28 Changed 6 years ago by Federico Montesino Pouzols

adjust constness, methods doc, and added the last methods, re #11392

Changeset: bb15baf1be0e63dd8beabc6443cf5a868f4d13b9

comment:29 Changed 6 years ago by Federico Montesino Pouzols

more test cases, re #11392

Changeset: 96adfe67098fc3faa639cdb730c135585d06c6a4

comment:30 Changed 6 years ago by Federico Montesino Pouzols

prefer TSM_ asserts, UNUSED_ARGS out, rename TestJM->FakeJM, re #11392

Changeset: 6cb85cf2f402be818f2af4e8e75085f7eb1674f8

comment:31 Changed 6 years ago by Federico Montesino Pouzols

improvmts in WS API test, new protected hooks for testing, re #11392

Changeset: 7ee54f282e126c387dbfa7242d49dd5d93a005b5

comment:32 Changed 6 years ago by Federico Montesino Pouzols

TODO comment for hard-coded url, it's in another ticket, re #11392

Changeset: 4f43fecd088d590d19499063ddf1fcb3ac1dff0d

comment:33 Changed 6 years ago by Federico Montesino Pouzols

add another ticket's number in comment to keep track of it, re #11392

Changeset: d4ad309948202adf66c0463cf2a7287b02deebf1

comment:34 Changed 6 years ago by Federico Montesino Pouzols

add tests for ok and err codes with and without err message, re #11392

Changeset: 9f621645c1da37d83eaf9cd34e48ac24b2be6241

comment:35 Changed 6 years ago by Federico Montesino Pouzols

fix static members init, re #11392

Changeset: 076525074d1444f24298532ca5c6901b04f78ad5

comment:36 Changed 6 years ago by Federico Montesino Pouzols

proper fix for test static data members, re #11392

Changeset: 325f15f44b854dec43d208f7b790ae8f58912e3a

comment:37 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/master' into 11392_create_MantidWebServiceAPIJobManage_from_RemoteAlgorithms_andRemoteJobManager

Conflicts:

Code/Mantid/Framework/API/inc/MantidAPI/RemoteJobManagerFactory.h Code/Mantid/Framework/API/test/RemoteJobManagerFactoryTest.h Code/Mantid/Framework/RemoteJobManagers/CMakeLists.txt

Sort out conflict in CMakeLists (files added in another PR, #503) and factory test, re #11392

Changeset: 847613dd82b4ca76c98603ff3918f8a7eb0d1840

comment:38 Changed 6 years ago by Federico Montesino Pouzols

fix messed up test names after merge, re #11392

Changeset: 710eaf2c679f5e3143f63abdfda9862efe0a5fe2

comment:39 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #521 from mantidproject/11392_create_MantidWebServiceAPIJobManage_from_RemoteAlgorithms_andRemoteJobManager

Create a job manager for the mantid web service / remote job submission API

Full changeset: ​71845669f2f4d4aead7174cfbd5c3e0df38a39dd

comment:40 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:41 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12231

Note: See TracTickets for help on using tickets.