Ticket #11393 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SmoothMD

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.4
Component: Direct Inelastic Keywords: VATES-cli
Cc: Blocked By: #8160
Blocking: #11231 Tester: Andrei Savici

Description

See design document ​https://github.com/mantidproject/documents/blob/master/Design/VATES/MantidHorace/syntax-proposal.md for the requirements for this new Algorithm.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #11393. New smoothing algorithm.

Changeset: 3d44e05682663ba242415008259084c17c392320

comment:2 Changed 6 years ago by Owen Arnold

refs #11393. Implement Hat Smooth.

Currently the MDHistoIterator can only give me a fixed-size neighbour map in a 3 by n block. Smooth demands that we can make the size of this block variable. Otherwise WidthVector will not be used.

Changeset: 23259741eb0c3d45220dca9dc5c11f54ad07aff4

comment:3 Changed 6 years ago by Owen Arnold

refs #11393. Iterator upgrade.

Can now find neighbours via a specified width. Unit tests introduced.

Changeset: 44c41f5afe25d7ec37e29230b191e498948573dc

comment:4 Changed 6 years ago by Owen Arnold

refs #11393. Cache iterator calculations.

Cache the permutation info by width.

Changeset: 95407c0471335aa484587ceafcf167373456d52f

comment:5 Changed 6 years ago by Owen Arnold

refs #11393. Refactor existing code.

Introduce additional performance test

Make findNeighbours use findNeighboursByWidth

Remove init code. All vertex touching calculations go through the cache now

Changeset: d302f786737ac28350737d52d87e01d13133dc8e

comment:6 Changed 6 years ago by Owen Arnold

refs #11393. Add tests for width.

Changeset: c47112a301a8941a98443d94e849e75e15465e8b

comment:7 Changed 6 years ago by Owen Arnold

refs #11393. Check for even widths.

Changeset: 6177a24569bad2ca6f23b585b8bb5706d163fedb

comment:8 Changed 6 years ago by Owen Arnold

refs #11393. Add parallel execution.

Changeset: 4a3bb333e23015e020d0eba355d26e055343d683

comment:9 Changed 6 years ago by Nick Draper

  • Keywords VATES-cli added; VATES removed
  • Milestone changed from Backlog to Release 3.4

comment:10 Changed 6 years ago by Owen Arnold

refs #11393. Add performance test.

Changeset: 1b51c6b6b452ebd6ef23a55eabd8a06dc0abc2a7

comment:11 Changed 6 years ago by Owen Arnold

refs #11393. Use OMP macros.

Changeset: 2ea79abecc242afc48b59289864b2b5991b343d9

comment:12 Changed 6 years ago by Owen Arnold

refs #11393. Add interupt.

Changeset: 8a599ea80f4b2eeeeca2175676773a4e67102c32

comment:13 Changed 6 years ago by Owen Arnold

refs #11393. Better reporting.

Changeset: fa1e5879ce3fca34edc6e4107405036cfbf1b3f5

comment:14 Changed 6 years ago by Owen Arnold

refs #11393. Add docs for alg.

Changeset: c0eb3e3dd02375f40423ef45d902ab9e69acd17a

comment:15 Changed 6 years ago by Owen Arnold

refs #11393. Improve documentation.

Changeset: e73d92a6d5ab60fdc2a6d37e16757d8fcc7c4993

comment:16 Changed 6 years ago by Owen Arnold

refs #11393. Centre images.

Changeset: d1287ee5e2e3f10a6eba732ff09c7d5657b0d57e

comment:17 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #487.

comment:18 Changed 6 years ago by Owen Arnold

refs #11393. Fix warnings.

Changeset: 9ebe4563a3ee1c8ae586f9f9e79ae20e9ca8fd5f

comment:19 Changed 6 years ago by Owen Arnold

refs #11393. Merge master in.

Merge branch 'master' into 11393_smooth_md

Changeset: 28f0952bf7797e908eb6b1ec3fe11666471d0c8d

comment:20 Changed 6 years ago by Owen Arnold

Jenkins test this please

comment:21 Changed 6 years ago by Andrei Savici

Is it possible to add a second input workspace (optional) as the weight? One should not create smoothed points where the weight is 0. For example, weight is: 1-0-0 1-1-0 1-1-1 Data should not haveany non-zero elements in the upper right corner, and neither should the output result.

comment:22 Changed 6 years ago by Owen Arnold

refs #11393. Fix type conversion warning.

Changeset: c66bd0c03a186c42f02c119b2942744415330122

comment:23 Changed 6 years ago by Owen Arnold

refs #11393. Normalization workspace option.

Changeset: ca696540ea264d96b282ed7db8aa844c9c8009d1

comment:24 Changed 6 years ago by Owen Arnold

Jenkins retest this please

comment:25 Changed 6 years ago by Owen Arnold

refs #11393. Allow variable widths.

This is what the horace function does, so we should do it here too.

Changeset: 4eb18b1e9f5020ccd211a1a9cb63537a51060783

comment:26 Changed 6 years ago by Owen Arnold

refs #11393. Remove unused free function.

Changeset: 5d3cd14dd53f59be253df592e394a39aa3f6d49b

comment:27 Changed 6 years ago by Owen Arnold

refs #11393. Remove unrelated file.

Changeset: 7f19cbd201d8a5c722aca23d80d2763bf387c2a9

comment:28 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:29 Changed 6 years ago by Owen Arnold

refs #11393. Fix merge conflicts.

Merge branch 'master' into 11393_smooth_md

Conflicts:

Code/Mantid/Framework/DataObjects/inc/MantidDataObjects/MDHistoWorkspaceIterator.h Code/Mantid/Framework/DataObjects/src/MDHistoWorkspaceIterator.cpp

Changeset: a8b0ade51d3a1b9184961f34bcc9a10392d87dbf

comment:30 Changed 6 years ago by Andrei Savici

Jenkins test this please

comment:31 Changed 6 years ago by Andrei Savici

There are still several cases of MDEvents instead of MantidDataObjects. Look for MDEvents in your code, in the include sections and in "using namespace Mantid::MDEvents;"

comment:32 Changed 6 years ago by Owen Arnold

refs #11393. Remove MDEvents namespace.

Changeset: a93ce4b3b79d3fae385a60ad40d943169d30dbd7

comment:33 Changed 6 years ago by Owen Arnold

refs #11393. Update header location.

Changeset: 30636b5224e31c623f8c61884be1844a2d32bb41

comment:34 Changed 6 years ago by Owen Arnold

Jenkins retest this please

comment:35 Changed 6 years ago by Owen Arnold

Jenkins retest this please

comment:36 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #487 from mantidproject/11393_smooth_md

SmoothMD algorithm

Full changeset: ​046b37f2984784417c4b44b7139416bb8e846568

comment:37 Changed 5 years ago by Owen Arnold

  • Blocking 11231 added

comment:38 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12232

Note: See TracTickets for help on using tickets.