Fix ET Plot Time issue

[Dan Nixon]

Using Plot Time in IDR>ET gives an exception and no plot.

[Dan Nixon]

Fix exception on Plot Time

Refs #11394

Changeset: 5bd075b56cb68fc83b07fcc74fab6b59b4666bdb

[Dan Nixon]

This is being verified as ​pull request #420.

[Dan Nixon]

Move spectrum selection to additional UI inputs

Previously could not plot time on a monitor

Refs #11394

Changeset: 7026a374f0f3cef0aa93ef86b5ed14789c8b7d8c

[Dan Nixon]

Update docs to reflect UI change

Refs #11394

Changeset: ab28c46c6ed54789a0c030b761db9719758e9ead

[Dan Nixon]

Jenkins, retest this please.

[Dan Nixon]

Jenkins, retest this please.

[Karl Palmen]

It does not work for me. I get exception when I try it on Windows 7. Test failed.

[Dan Nixon]

Fix new exception Refs #11394

Changeset: ef31ebcedac5f040d1c11cce83eb0745e4260520

[Dan Nixon]

Jenkins, retest this please.

[Karl Palmen]

I still get a type exception for the minimum spectrum.

[Dan Nixon]

Use correct type for spectra properties

Refs #11394

Changeset: 888e1e29126521f998904dd02c0aa8b8c14994ce

[Dan Nixon]

Merge branch '11394_fix_et_plot_time' of github.com:mantidproject/mantid into 11394_fix_et_plot_time

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/ISISEnergyTransfer.cpp

Refs #11394

Changeset: e3a73aed3a194f09f5dd8b32ac044b3c32afbc0b

[Dan Nixon]

Jenkins, retest this please.

[Karl Palmen]

The test makes more progress but fails having successfully run several child algorithms. It fails with a type error when it loads again.

The error shown to the results log is: InelasticIndirectReduction successful, Duration 2.30 seconds Load started Cannot process ICPevent log. Period 1 assumed for all data. Load successful, Duration 2.59 seconds Algorithm property given value of incorrect type. Stopping queue execution. Got error from algorithm "GroupDetectors" Stopping batch algorithm because of execution error

[Dan Nixon]

@KarlPalmen Actually now that you mention GroupDetectors I have noticed another issue with the routine that needs to be fixed.

[Dan Nixon]

Fix issue with range of grouped dets

Refs #11394

Changeset: 5c8a8e81334951ff42f1edd055b06f7192e2ef59

[Dan Nixon]

Jenkins, retest this please.

[Dan Nixon]

Jenkins, retest this please.

[Dan Nixon]

Jenkins, retest this please.

[Dan Nixon]

I've given up trying to get the CI to pass on this, over the last 3 retests it has passed on all platforms so should be OK to be tested now.

[Karl Palmen]

It works for me (on Windows 7).

[Dan Nixon]

Jenkins, retest this please.

[Karl Palmen]

It works again, but I have noticed, that when I plot again and create a new graph in a new window, the previous graphs are updated to look like the new graph. Is this supposed to happen?

[Dan Nixon]

@KarlPalmen That's just an issue with plotting, it happens on quite a few indirect interfaces. There is an existing [ticket](​http://trac.mantidproject.org/mantid/ticket/8236) to fix this.

[Dan Nixon]

I think this should be OK to merge, I have well and truly given up with Jenkins now, everything that needs to have passed has passed (just not at the same time).

[Nick Draper]

​https://github.com/mantidproject/mantid/pull/420

[Dan Nixon]

Merge branch '11394_fix_et_plot_time' of github.com:mantidproject/mantid into 11394_fix_et_plot_time

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/ISISEnergyTransfer.cpp

Refs #11394

Full changeset: ​e3a73aed3a194f09f5dd8b32ac044b3c32afbc0b

[Karl Palmen]

Merge pull request #420 from mantidproject/11394_fix_et_plot_time

Fix exception on ISIS Energy Transfer > Plot Time

Full changeset: ​98b89268ed3babe8923289ce6ceeabb85975dda1

[Stuart Campbell]

This ticket has been transferred to github issue ​12233