Ticket #11414 (closed: fixed)
Create an algorithm to add multiple sample logs to a workspace
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Michael Wedel |
Description (last modified by Dan Nixon) (diff)
Code to do this already exists in IndirectCommon but I'm trying to avoid having to use this in more general algorithms not specific to indirect.
It should take the workspace as an In/Out property and two lists of strings for the keys/values, if a string can be interpreted as a number the log type will be set to number.
Change History
comment:8 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #440.
comment:9 Changed 6 years ago by Michael Wedel
- Status changed from verify to verifying
- Tester set to Michael Wedel
comment:10 Changed 6 years ago by Michael Wedel
- Status changed from verifying to closed
Merge pull request #440 from mantidproject/11414_addsamplelogmultiple_algorithm
Code and tests look very clear, example works well, tried also with different values. There's a small typo in the documentation, it says "multiple sample log enteries". I would suggest fixing this through github as discussed in the developer meeting to avoid running the whole build process again.
Full changeset: f11d30470d21e290e4a55c90e550c253eee8109c
comment:11 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12253
