Ticket #11424 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Pan tool zoom remains enabled after right click

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: minor Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

To reproduce:

  • Plot some data on a standard Mantid plot
  • Enable the Pan tool
  • Right click on the plot
  • Click back on the plot
  • Move the mouse
  • Notice zooming is enabled by default and has to be cancelled by clicking on the plot a second time

I had this issue in PreviewPlot but managed to fix it somehow.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Owner set to Dan Nixon

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Disable the mouse button on the magnifier

Fixes an issue with this locking zoom on after the context menu is shown using right click

Refs #11424

Changeset: 5ea1dc0d6c523fe2ce7fff86830d57ebb6025742

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #457.

comment:4 Changed 6 years ago by Karl Palmen

I tried this on the version I built for my previous test and noticed no such problem when doing the test on it.

comment:5 Changed 6 years ago by Harry Jeffery

I'm able to reproduce this on my machine. Presumably it's platform dependant, as Dan and I both run Linux with i3 as our desktop environment.

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:7 Changed 6 years ago by Dan Nixon

I did try this on Windows and it does not seem to be an issue, I kind of think this is just an issue with i3wm but may as well be fixed anyway since previously there were two functions (attempting to) be assigned to right click.

comment:8 Changed 6 years ago by Harry Jeffery

Fix has the desired effect and doesn't seem to have broken anything.

comment:9 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #457 from mantidproject/11424_fix_plot_zoom_after_right_click

Fix graph zooming after context menu is shown

Full changeset: ​b58c8b79bbc3a8ef5e972104fdcb6de3d4986564

comment:10 Changed 5 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.4

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12263

Note: See TracTickets for help on using tickets.