Ticket #11426 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Tidy ConvFit sample log code

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: minor Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

This can be done in a single call to AddSampleLog multiple now, doing this makes the debug log more useful as it is not full of AddSampleLog.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to inprogress

Use AddSampleLogMultiple in ConvFit

Refs #11426

Changeset: ed7ed7a7cf326809816e16040fdca0c9b695a20f

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #458.

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:4 Changed 6 years ago by Harry Jeffery

Ignoring the cppcheck error, as this doesn't even touch C++ code.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #458 from mantidproject/11426_use_addsamplelogmultiple_in_convfit

Use AddSampleLogMultiple in ConvFit

Full changeset: ​cbbfc4abef2b6f429ac5a86c6986e50f58bbf531

comment:6 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12265

Note: See TracTickets for help on using tickets.