Ticket #11429 (closed: fixed)
Stitch1DMany overwrites output workspace
| Reported by: | Nick Draper | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Wedel |
Description (last modified by Harry Jeffery) (diff)
Stitch1DMany overwrites the output workspace from a previous stitch, it would be better to to keep the old workspaces to allow comparison.
Change History
comment:2 Changed 6 years ago by Harry Jeffery
Refs #11429 Don't overwrite workspaces by mistake
Changeset: a7e84242c1fc3618bb40a495e4ec0f1c40182f08
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #495.
comment:5 Changed 6 years ago by Michael Wedel
- Status changed from verify to verifying
- Tester set to Michael Wedel
comment:6 Changed 6 years ago by Michael Wedel
- Status changed from verifying to closed
Merge pull request #495 from mantidproject/11429_stitch1dmany_overwrites_output
I tested the changes running this slightly modified usage example, which puts each of the workspaces into a WorkspaceGroup first. Without these changes the two resulting WorkspaceGroups contain the same workspace (the first one is overwritten), after the changes this does not happen, as described in the ticket.
` trans1 = Load('INTER00013463') trans2 = Load('INTER00013464')
trans1_wav = CreateTransmissionWorkspaceAuto(trans1) trans2_wav = CreateTransmissionWorkspaceAuto(trans2)
wsGroup1 = GroupWorkspaces("trans1_wav") wsGroup2 = GroupWorkspaces("trans2_wav")
stitched_wav1, y = Stitch1DMany("wsGroup1,wsGroup2", params='1, 0.02, 17', UseManualScaleFactor=True, ManualScaleFactor=0.85) stitched_wav2, y = Stitch1DMany("wsGroup1,wsGroup2", params='1, 0.05, 17', UseManualScaleFactor=True, ManualScaleFactor=3.85) `
Full changeset: 9a14d63e12a75d76df1aa657cf6c869832eccd2a
