Ticket #11446 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Replace plotting in indirect interfaces with functions in IndirectTab

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By: #11326
Blocking: Tester: Harry Jeffery

Description

In #11326 code was added in the base class for indirect UI tabs that handles plotting, all plotting done from the UI should be swapped to use this instead of having to use Python in each interface.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Blocked By 11326 added

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Switch over most plotting

Need a way to specify a range Renames plotContour to plot2D to match Python API

Refs #11446

Changeset: da9b30608d258c46ef5c967ea15083d0215a3abd

comment:3 Changed 6 years ago by Dan Nixon

Add way to plot a spectra range, use on Sqw

Refs #11446

Changeset: 8ba619077f47cff32bca6b0c18aa12c39eb8cb8a

comment:4 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 11446_use_new_indirect_plotting_in_all_interfaces

Refs #11446

Changeset: f49fd0154e5ae1e1e578f503d594a688d4456fab

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #502.

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:7 Changed 6 years ago by Harry Jeffery

Changes look sensible and the plotting works. The only failure is in the default build, specifically on the OSX target. The failure is a random test failure, and the main OSX build succeeded so I'm disregarding the random failure.

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #502 from mantidproject/11446_use_new_indirect_plotting_in_all_interfaces

Use new indirect plotting in all interfaces

Full changeset: ​84f14c0c664816aeb02b9b662afd141714d67d76

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12285

Note: See TracTickets for help on using tickets.