Ticket #11455 (closed: fixed)
Instantiate Projection from ITableWorkspace
| Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Harry Jeffery) (diff)
It's currently possible to create an ITableWorkspace from a Projection, but not the other way around.
There should be a constructor for Projection that takes an ITableWorkspace_sptr and uses that to instantiate itself.
Change History
comment:2 Changed 6 years ago by Harry Jeffery
- Description modified (diff)
- Summary changed from Instanciate Projection from ITableWorkspace to Instantiate Projection from ITableWorkspace
comment:3 Changed 6 years ago by Harry Jeffery
Refs #11455 Add ITableWorkspace -> Projection constructor
Changeset: a7cc67afcd9f3f23d69dcc3f61ce2b10464d887d
comment:4 Changed 6 years ago by Harry Jeffery
Refs #11455 Increase robustness of table parsing
Changeset: d913b14ae63a472f9c6d7768321df17216e67f51
comment:5 Changed 6 years ago by Harry Jeffery
Refs #11455 Unit test Projection from table constructor
Changeset: 7ed94f66c657657e19f7e6d08e96f05742aee469
comment:6 Changed 6 years ago by Harry Jeffery
Refs #11455 Replace CutMD utility functions with Projection type
Changeset: 64950c1a1332dcd6d19ed27530730c7ddbc99b12
comment:7 Changed 6 years ago by Harry Jeffery
Refs #11455 Remove obsolete unit tests
Changeset: 7cec35e8b0008646f4efe40b49fb69b2ead49a0d
comment:8 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #504.
comment:9 Changed 6 years ago by Harry Jeffery
Refs #11455 Add TableWorkspaceTester and ColumnTester
Changeset: 6571f342844173fade22e4bca1471cfad47bd662
comment:10 Changed 6 years ago by Harry Jeffery
Refs #11455 Create custom fakes for testing
Changeset: aa2ce0aa1b4d2e863ce11ad1c9fc634d94d07bee
comment:11 Changed 6 years ago by Harry Jeffery
Refs #11455 Check projection input column count
Changeset: e5b3555445f9294560e39b1c2c7cc31948325155
comment:12 Changed 6 years ago by Harry Jeffery
Refs #11455 Use custom fakes in unit tests
Changeset: f5bae4d35742b6ee4c5d54f07c7e268ed9b5aad1
comment:13 Changed 6 years ago by Harry Jeffery
Refs #11455 Don't include DataObjects in APITests
Changeset: f3309b2ccb0b3909a98bfaf86a581e216def2e1a
comment:14 Changed 6 years ago by Harry Jeffery
Refs #11455 Correct incomplete revert
Changeset: 42daebdbe830725daca81a4c041dc43ef0484339
comment:15 Changed 6 years ago by Harry Jeffery
Jenkins, retest this please.
comment:16 Changed 6 years ago by Harry Jeffery
Jenkins, retest this please.
comment:17 Changed 6 years ago by Harry Jeffery
retest this please
comment:18 Changed 6 years ago by Harry Jeffery
comment:19 Changed 6 years ago by Harry Jeffery
Refs #11455 Remove superfluous length checks
Changeset: 985e441f85ce49dc6387112e3ee8553f1551348f
comment:20 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:21 Changed 6 years ago by Harry Jeffery
Refs #11455 Construct Projection from const ITableWorkspace&
Changeset: 00ae3569ae8695977db9a385844ca4ef7617cd84
comment:22 Changed 6 years ago by Harry Jeffery
Refs #11455 Reduce calls to getColumn
Changeset: 04957f3d07725cd57d0176192c6dba3d604c9d23
comment:23 Changed 6 years ago by Harry Jeffery
Refs #11455 Update Projection table format
Change the type of the 'value' column from 'str' to 'V3D'.
Changeset: cf431563eef32dd65e242cb4e576590b2a97eecd
comment:24 Changed 6 years ago by Harry Jeffery
Refs #11455 Fix build on OSX
Changeset: 927ce5e9b3739f10c918901894f5ee34184ea95b
comment:25 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge pull request #504 from mantidproject/11455_instantiate_projection_from_itableworkspace
Allow Projections to be instantiated from a table workspace
Full changeset: 5e65b4a11ce20fa392d0e29117228c16b6b71511
comment:26 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:27 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12294
