Ticket #11458 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Rename file in LoadFullProfResolutionTest

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Pete Peterson

Description (last modified by Steven Hahn) (diff)

LoadFullProfResolutionTest is occasionally failing with an error like

libc++abi.dylib: terminating with uncaught exception of type std::invalid_argument: Invalid value for property Filename (string) "TestWorskpace.irf": File "TestWorskpace.irf" not found

Martyn found that both LoadGSASInstrumentFileTest and LoadFullProfResolutionTest write a file named TestWorskpace.irf. The simplest fix is to rename both files so that they no longer conflict.

Change History

comment:1 Changed 6 years ago by Steven Hahn

  • Status changed from new to inprogress

Refs #11458. Add 0.5s pause between writing and reading file.

Changeset: 80993c5a036ee59f53c4e87754f3fa43c34d9260

comment:2 Changed 6 years ago by Steven Hahn

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #499.

comment:3 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:4 Changed 6 years ago by Steven Hahn

LoadGSASInstrumentFileTest and LoadFullProfResolutionTest use the same name. That is more likely causing the issues. Closing this pull request without merging and will resubmit a new pull request with a renamed file.

comment:5 Changed 6 years ago by Steven Hahn

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Description modified (diff)
  • Summary changed from add pause in LoadFullProfResolutionTest to Rename file in LoadFullProfResolutionTest

comment:6 Changed 6 years ago by Steven Hahn

  • Status changed from reopened to inprogress

Refs #11458. Rename files with the same name.

Changeset: 2b6c02d1a3ecb6bcc719c155d8d920b1fcab096b

comment:7 Changed 6 years ago by Steven Hahn

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #500.

comment:8 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying

comment:9 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #500 from mantidproject/11458_rename_TestWorskpace

The failed system test is unrelated to this.

Full changeset: ​b0e75634cddf3a65f44a5e5ff4631355df1d4400

comment:10 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12297

Note: See TracTickets for help on using tickets.