Ticket #11466 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix a coverity issue in FABADA.cpp

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description 

*** CID 1292665:  API usage errors  (INVALIDATE_ITERATOR)
/home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/Framework/CurveFitting/src/FABADAMinimizer.cpp: 450 in Mantid::CurveFitting::FABADAMinimizer::finalize()()
444         }
445         // make sure the iterator is valid in any case
446         auto pos_right = rc_chain_j.end() - 1;
447         if (sigma < static_cast<size_t>(std::distance(pos_par, pos_right))) {
448           pos_right = pos_par + sigma;
449         }
>>>     CID 1292665:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Dereferencing iterator "pos_par" though it is already past the end of its container.
450         error_left[j] = *pos_left - *pos_par;
451         error_rigth[j] = *pos_right - *pos_par;
452       }
453     
454       const bool outputParametersTable = !getPropertyValue("Parameters").empty();
455

Change History

comment:1 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:2 Changed 5 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Re #11466. Fixing the issue.

Changeset: 5c401a163003f672beaddc5e43590028df5277a5

comment:3 Changed 5 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #814.

comment:4 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:5 Changed 5 years ago by Federico Montesino Pouzols

The changes make sense and should fix this issue. I'll ignore the DownloadFileTest failure which is absolutely unrelated.

comment:6 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #814 from mantidproject/11466_coverity_issue_in_fabada

Coverity issue in FABADA code.

Full changeset: ​68f53d08eeab1c33b5f2dbf83d281c069d9a63a0

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12305

Note: See TracTickets for help on using tickets.