Ticket #11469 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bugfix: LoadMD does not load MDEventData correctly if initial splitting was applied

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: Framework Keywords: VATES
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Anton Piccardo-Selg) (diff)

Context

As part of the VATES AA an option to produce a forced initial splitting was added to the ConvertToMD algorithm. This produces a workspace which has a forced splitting in its first level of 50x50x50x50.

This is implemented by resetting the SplitInto option of the box controller to our desired values, letting the first box split and setting the SplitInto option back to its original value.

Issue

When the MDEventWorkspace is saved via SaveMD this knowledge of the initial splitting is lost, but it stores the original SplitInto option of the box controller. When the LoadMD algorithm is called to reload the data the expected size of the MDGridBox, which is read out from the SplitInto option and the actual size of the MDGridBox are not matched, which can cause an out of bounds error.

This means, that workspaces which have had a forced initial split applied to them cannot be saved and reloaded in a proper way.

Attachments

BuildSQW_splitting.py​ (3.0 KB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Anton Piccardo-Selg

  • Owner changed from Anton Piccardo-Selg to Nick Draper
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anton Piccardo-Selg

  • Owner changed from Nick Draper to Anton Piccardo-Selg

comment:3 Changed 6 years ago by Anton Piccardo-Selg

  • Description modified (diff)

comment:4 Changed 6 years ago by Anton Piccardo-Selg

  • Milestone changed from Backlog to Release 3.4

comment:5 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from assigned to inprogress

Refs #11469 Add top level split storage to box controller

Changeset: c57e397bfc9f6775f9845411f86e258844b525af

comment:6 Changed 6 years ago by Anton Piccardo-Selg

Refs #11469 Fix for loading initial split data vsi

Changeset: 0d4fe7dce395bb1b1d7c6286801ca9dde7a5d927

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Refs #11469 Added unit tests to box controller

Changeset: 73075b64a1f8bacbfc1ced58d0294d2861067248

comment:8 Changed 6 years ago by Anton Piccardo-Selg

Refs #11469 Resolving merge issue in box controller

Changeset: d3f847a15b1b206021c90f8d4fad3774215ad622

comment:9 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #532.

comment:10 Changed 6 years ago by Anton Piccardo-Selg

Refs #11469 Fix cpp check issue

Changeset: e500bf3fc14de3830dfb0fc0bc9114d01e3697eb

comment:11 Changed 6 years ago by Anton Piccardo-Selg

Refs #11469 Fix compiler warnings

Changeset: 7c26ba46e3c44e81db01d4e531e88f12b7209da9

Changed 6 years ago by Anton Piccardo-Selg

comment:12 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:13 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #532 from mantidproject/bugfix/11469_fix_loadMD_issue_from_initial_splitting

Fix load issue for MD workspaces which have top level splitting

Full changeset: ​9b1c5dcdb0fd8aaf5556e2b2cc62a5467719054a

comment:14 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12308

Note: See TracTickets for help on using tickets.