Ticket #11470 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SumSpectra option on LoadVesuvio is broken

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Run LoadVesuvio with spectra 3-198 and either single, double or thick difference and the X values of the workspace are all zero.

On foil in, out or in/out it just doesn't sum anything.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Set X values on summed spectrum

Refs #11470

Changeset: ffe089aec79d821cf70e4272538830275f6b64ab

comment:3 Changed 6 years ago by Dan Nixon

Update system test to check X values

Refs #11470

Changeset: f851e5ebf4f9a750e505951454047e11c988505f

comment:4 Changed 6 years ago by Dan Nixon

Support SumSpectra on foil modes

Refs #11470

Changeset: c27c98c96e6634bbf4863028a47c348aacacc400

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #516.

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 6 years ago by Martyn Gigg

I've just realised there is another problem with the summing - it is not setting the correct spectrum numbers and IDs. I'll update this branch with a fix that I have.

comment:8 Changed 6 years ago by Martyn Gigg

Fix the spectrum numbering when summing the detectors

Refs #11470

Changeset: 6e51605e30670821e9e5c7f3c30f734a34ed2fb3

comment:9 Changed 6 years ago by Martyn Gigg

The data and spectrum numbers both look good now.

comment:10 Changed 6 years ago by Dan Nixon

Set X values on summed spectrum

Refs #11470

Changeset: ffe089aec79d821cf70e4272538830275f6b64ab

comment:11 Changed 6 years ago by Dan Nixon

Update system test to check X values

Refs #11470

Changeset: f851e5ebf4f9a750e505951454047e11c988505f

comment:12 Changed 6 years ago by Dan Nixon

Support SumSpectra on foil modes

Refs #11470

Changeset: c27c98c96e6634bbf4863028a47c348aacacc400

comment:13 Changed 6 years ago by Martyn Gigg

Fix the spectrum numbering when summing the detectors

Refs #11470

Changeset: 6e51605e30670821e9e5c7f3c30f734a34ed2fb3

comment:14 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #516 from mantidproject/11470_loadvesuvio_sum_option_fix

Fix SumSpectra option on LoadVesuvio

Full changeset: 9cfc845d0fa1b017d18519261de6c71a674920f0

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12309

Note: See TracTickets for help on using tickets.