Ticket #11486 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadISISNexus does not load multi-period monitors when specifying LoadMonitors='Separate'

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description (last modified by Martyn Gigg) (diff)

A good example file is run 33772 on Offspec. Separating the monitors works for Raw but not for Nexus making Load impossible to use generically in the Offspec recent scripts.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from new to inprogress

Implement loading monitors separately for ISIS NeXus

Refs #11486

Changeset: 702d1904e058ce15b8ca75ce7f9d47cbcee779e5

comment:4 Changed 6 years ago by Martyn Gigg

Add a test for separating monitors in multiperiod NeXus

Refs #11486

Changeset: af16c693addb7fa807c0b6afcb944a5f166a8b62

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #537.

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:7 Changed 6 years ago by Dan Nixon

When loading monitors separately I the monitor workspace for the first period looks correct (only 3 spectra, all are monitors) however all other periods seem to have monitors and detectors.

comment:8 Changed 6 years ago by Martyn Gigg

That's not good! I'll take a look.

comment:9 Changed 6 years ago by Martyn Gigg

Fix bug with separated monitor spectra.

The workspace factory as being passed the wrong workspace to clone from. Refs #11486

Changeset: 1c3ebd9df061ab4fee225f0f709950cee440fa42

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #537 from mantidproject/11486_fix_separate_multiperiod_monitors_isis_nexus

Fix LoadISISNexus & LoadMonitors='separate' for multi-period data

Full changeset: ​8bbed0bfbd9cd578e45cb406c049f70876929672

comment:11 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12325

Note: See TracTickets for help on using tickets.