Ticket #11490 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

validateInputs on TimeSlice is never called

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez

Description

The validation function on the TimeSlice algorithm is missing the final s, hence never called.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Correct the obvious error

Refs #11490

Changeset: fe4da940ede5561b42025230c49961d8fd49384c

comment:3 Changed 6 years ago by Dan Nixon

Unit test TimeSlice vlidation

Refs #11490

Changeset: ff98576b20d6b78e6982421fbf6c901ef69720e8

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #533.

comment:5 Changed 6 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:6 Changed 6 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #533 from mantidproject/11490_validateinputs_never_called_on_time_slice

ValidateInputs is never called on TimeSlice

Full changeset: ​7330325acaf880194af2157937f3f1953d9327f8

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12329

Note: See TracTickets for help on using tickets.