Ticket #11511 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

CreateMD filebacked

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.4
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Have a mode whereby CreateMD can be run file backed.

  • Allow files to be passed as inputs as well as workspaces
  • Add missing EFixed input parameter following Horace convention
  • Allow ConvertToMD to overwrite in-place
  • Set the File backed mode as an option. It won't be what people always want to do

Merging together existing MDWorkspaces as part of CreateMD will be handled separately

Change History

comment:1 Changed 5 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #11511. Add EFixed and DataSources property

Changeset: 9ecb525d172cec171efd58f7be4003cc9205ba62

comment:2 Changed 5 years ago by Owen Arnold

refs #11511. Update documentation and tests.

Changeset: 9844a0481aab9806bee303ab55a049bcb7eac334

comment:3 Changed 5 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #563.

comment:4 Changed 5 years ago by Harry Jeffery

You seem to be passing the new EFix property into the algorithm in the doc tests as EFixed. The documentation also refers to it as EFixed.

comment:5 Changed 5 years ago by Owen Arnold

refs #11511. Fix doctest.

Changeset: 89b78c2069305a3d7940c607b712712b37c74e8b

comment:6 Changed 5 years ago by Dan Nixon

Is there a reason the parameter is not called EFixed as this is what this value is referred to in most other algorithms.

comment:7 Changed 5 years ago by Owen Arnold

@DanNixon The reason is to keep consistency with the Horace convention since CreateMD is a port of [gen_sqw](​http://horace.isis.rl.ac.uk/Generating_SQW_files). If we are using EFixed consistently in other areas of Mantid, that would be a good case to adopt EFixed rather than continuing to use EFix

comment:8 Changed 5 years ago by Dan Nixon

@OwenArnold That makes sense for Horace consistencey.

I suppose the best option would be some sort of parameter aliasing.

comment:9 Changed 5 years ago by Martyn Gigg

Conflicts with master have arisen.

comment:10 Changed 5 years ago by Owen Arnold

refs #11511. Fix merge conflicts

Merge branch 'master' into 11511_create_md_filebacked

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/CreateMD.py

Changeset: fcf77c4cc033f8bab14de0cea3c5d317bc207f64

comment:11 Changed 5 years ago by Owen Arnold

refs #11511. Add EFixed and DataSources property

Changeset: 9ecb525d172cec171efd58f7be4003cc9205ba62

comment:12 Changed 5 years ago by Owen Arnold

refs #11511. Update documentation and tests.

Changeset: 9844a0481aab9806bee303ab55a049bcb7eac334

comment:13 Changed 5 years ago by Owen Arnold

refs #11511. Fix doctest.

Changeset: 89b78c2069305a3d7940c607b712712b37c74e8b

comment:14 Changed 5 years ago by Owen Arnold

refs #11511. Fix merge conflicts

Merge branch 'master' into 11511_create_md_filebacked

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/CreateMD.py

Changeset: fcf77c4cc033f8bab14de0cea3c5d317bc207f64

comment:15 Changed 5 years ago by Owen Arnold

refs #11511. Add EFixed and DataSources property

Changeset: 9ecb525d172cec171efd58f7be4003cc9205ba62

comment:16 Changed 5 years ago by Owen Arnold

refs #11511. Update documentation and tests.

Changeset: 9844a0481aab9806bee303ab55a049bcb7eac334

comment:17 Changed 5 years ago by Owen Arnold

refs #11511. Fix doctest.

Changeset: 89b78c2069305a3d7940c607b712712b37c74e8b

comment:18 Changed 5 years ago by Owen Arnold

refs #11511. Fix merge conflicts

Merge branch 'master' into 11511_create_md_filebacked

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/CreateMD.py

Changeset: fcf77c4cc033f8bab14de0cea3c5d317bc207f64

comment:19 Changed 5 years ago by Owen Arnold

refs #11511. Fix old params

Changeset: 8f96136fc99aa1713bac72605636033b61c91de2

comment:20 Changed 5 years ago by Owen Arnold

refs #11511. Fix pylint issues.

Changeset: 62b73aef0cf4f09ad2639e1760f7261d6adf87d5

comment:21 Changed 5 years ago by Owen Arnold

refs #11511. Fix pylint issues unrelated.

Pylint issues were detected for CreateMD.py. Since I can't resolve all of them, I'm helping out by reducing others elsewhere.

Changeset: cae3d7e72097ac8d57c719ef87fa6251047c539e

comment:22 Changed 5 years ago by Owen Arnold

refs #11511. Fix more pylint issues.

Changeset: 4912be4de701dbc2956b8d5facef23b0a75635c0

comment:23 Changed 5 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:24 Changed 5 years ago by Owen Arnold

refs #11511. Fix RST

Changeset: 690be0c0381f17fe3244264cf7808e7002bfa53b

comment:25 Changed 5 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #563 from mantidproject/11511_create_md_filebacked

11511 create md filebacked

Full changeset: ​18adf6b47c88afcf1fc46ae317a5f2fd9ad1e921

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12349

Note: See TracTickets for help on using tickets.