Ticket #11561 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Add FABADA option to ConvFit and IqtFit

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.5
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #11582, #11651
Blocking: #11241, #11581, #11729 Tester: Raquel Alvarez

Description

Add option to set minimizer to FABADA.

Will need additional options for:

  • PDF and chain outputs
  • MaxIteration
  • ChainLength

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Blocking 11241 added

comment:3 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Add fabada options to COnvFit UI

Refs #11561

Changeset: 6b86527bae23c4278ed8559ac7ff2296e5b350f2

comment:4 Changed 5 years ago by Dan Nixon

Add code for single fit

Refs #11561

Changeset: 7d646251fde5556ae223b2267c3125d260d4ba18

comment:5 Changed 5 years ago by Dan Nixon

Remove no longer required option

Refs #11561

Changeset: f44e84541ac4ae157db7f8aabdf346b39ccda963

comment:6 Changed 5 years ago by Dan Nixon

Default to a higher MaxIteration limit for FABADA

Refs #11561

Changeset: 6bfb9413035ec1176e44101f6373f7707313b71d

comment:7 Changed 5 years ago by Dan Nixon

  • Blocked By 11582 added

comment:8 Changed 5 years ago by Dan Nixon

Merge branch 'master' into 11561_convfit_furyfit_fabada

Refs #11561

Changeset: 39a33f16c6b4d70841de1e4278da583b92ee0dd2

comment:9 Changed 5 years ago by Dan Nixon

  • Blocked By 11651 added

comment:10 Changed 5 years ago by Dan Nixon

Add ability to use FABADA on seq fit

Refs #11561

Changeset: 7d384329356bfb8299f5baa7561d049c4a726590

comment:11 Changed 5 years ago by Dan Nixon

Dont output the chain by default

Refs #11561

Changeset: 9b69cd385caf09dd5e63e2e53253d5643569a5a2

comment:12 Changed 5 years ago by Dan Nixon

  • Blocked By 11676 added

comment:13 Changed 5 years ago by Dan Nixon

Support FABADA for single fit on IqtFit

Refs #11561

Changeset: b45aa5050d426809db8f1f14c11c56e7fb290ffe

comment:14 Changed 5 years ago by Dan Nixon

Add ability to do a sequential fit

Refs #11561

Changeset: 6e4c326e806888840535d2073219e782afca864a

comment:15 Changed 5 years ago by Dan Nixon

Merge branch 'master' into 11561_convfit_furyfit_fabada

Refs #11561

Changeset: 3a56fd53ecd2309d6ab1d231a67de060afeef7f8

comment:16 Changed 5 years ago by Dan Nixon

Merge branch '11651_plotpeakbylogvalue_minimizer_string' into 11561_convfit_furyfit_fabada

Refs #11561

Changeset: 2431adfe7470cbab459c00493644b4369c2607e9

comment:17 Changed 5 years ago by Dan Nixon

Document new options

Refs #11561

Changeset: 16f916485a640553221181493dc10ba58aa8c35a

comment:18 Changed 5 years ago by Dan Nixon

Set the FABADA name correctly

Refs #11561

Changeset: 0912bebd25c8108f6fb09946a9b5b36e1d552392

comment:19 Changed 5 years ago by Dan Nixon

Add note of using FABADA

Refs #11561

Changeset: 62e7d723276279b150824064e9f1edc4974a6976

comment:20 Changed 5 years ago by Dan Nixon

  • Blocking 11729 added

comment:21 Changed 5 years ago by Dan Nixon

  • Blocking 11581 added

comment:22 Changed 5 years ago by Dan Nixon

  • Blocked By 11676 removed

comment:23 Changed 5 years ago by Dan Nixon

Merge branch 'master' into 11561_convfit_furyfit_fabada

Refs #11561

Changeset: 24c185596f74dcdf731be83d53810d66260ea841

comment:24 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #768.

comment:25 Changed 5 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:26 Changed 5 years ago by Raquel Alvarez

You have to give very good starting parameters, otherwise Mantid crashes because of the minimizer (this has been reported in trac issue #11578(​http://trac.mantidproject.org/mantid/ticket/11578)). I have been able to fit the datasets using Two Lorentzians plus a Linear background and using starting values from a previous fit without the FABADA minimizer.

Also, the corresponding entry in the release notes has been added: http://www.mantidproject.org/Release_Notes_3_5_Indirect_Inelastic

comment:27 Changed 5 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #768 from mantidproject/11561_convfit_furyfit_fabada

Add FABADA option to I(Q, t) fit and ConvFit

Full changeset: ​da36d79dc63ef37a010303b988e779c49ce314e4

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12399

Note: See TracTickets for help on using tickets.