Ticket #11568 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Fix coverity issues in the multi-dataset fit interface

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

*** CID 1294007:  Uninitialized members  (UNINIT_CTOR)
/home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/MantidQt/CustomInterfaces/src/MultiDatasetFit/MDFAddWorkspaceDialog.cpp: 37 in MantidQt::CustomInterfaces::MDF::AddWorkspaceDialog::AddWorkspaceDialog(QWidget *)()
31         }
32       }
33       connect(m_uiForm.cbWorkspaceName,SIGNAL(currentIndexChanged(const QString&)),this,SLOT(workspaceNameChanged(const QString&)));
34       m_uiForm.cbWorkspaceName->addItems( workspaceNames );
35     
36       connect(m_uiForm.cbAllSpectra,SIGNAL(stateChanged(int)),this,SLOT(selectAllSpectra(int)));
>>>     CID 1294007:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_maxIndex" is not initialized in this constructor nor in any functions that it calls.
37     }
38     
39     /// Slot. Reacts on change of workspace name in the selection combo box.
40     /// @param wsName :: Name of newly selected workspace.
41     void AddWorkspaceDialog::workspaceNameChanged(const QString& wsName)
42     {

Change History

comment:1 Changed 5 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Re #11568. Init the variable.

Changeset: 3ce371e2326ddf6736d4cb976f393f22fabd8270

comment:2 Changed 5 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #595.

comment:3 Changed 5 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:4 Changed 5 years ago by Roman Tolchenov

Re #11568. Init the variable.

Changeset: 3ce371e2326ddf6736d4cb976f393f22fabd8270

comment:5 Changed 5 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #595 from mantidproject/11568_coverity_issue_multidata_fitting

Coverity issue in the multi-dataset fit interface

Full changeset: 6602a1c61f00c059da20842299c9deb403d7ec10

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12406

Note: See TracTickets for help on using tickets.