Ticket #11582 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

FABADA outputs are non optional

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #11561 Tester: Roman Tolchenov

Description

Do a fit with FABADA and clear the PDF, Chains, ConvergedChain, CostFunctionTable and Parameters options.

You would expect those workspaces to not be crated now, they still are using the default names.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Remove default values for non essential outputs

Refs #11582

Changeset: 7bca78ba520514a0c290cf48b352e4003b93c386

comment:3 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #600.

comment:4 Changed 5 years ago by Dan Nixon

Add output parameters where needed to test

Refs #11582

Changeset: 23a57b028727f333a8b21556cf9bee897e0f70a9

comment:5 Changed 5 years ago by Dan Nixon

  • Blocking 11561 added

comment:6 Changed 5 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 5 years ago by Roman Tolchenov

Having the defaults was a design decision by FABADA's developer Diego. From whom the requirement to remove them is coming?

comment:8 Changed 5 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #600 from mantidproject/11582_fabada_disable_unwanted_output

Remove default values for non essential outputs on FABADA

Full changeset: ​d47d9dcf5585020fd70e8a66e4f67c70edc94804

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12420

Note: See TracTickets for help on using tickets.