Ticket #11612 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

REFL scaling factor for 30Hz operation

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.4
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Refactor the REFL scaling factor algorithm and make sure it works for 30Hz operation.

Change History

comment:1 Changed 5 years ago by Mathieu Doucet

  • Component changed from Framework to Reflectometry

comment:2 Changed 5 years ago by Mathieu Doucet

  • Status changed from new to inprogress

Re #11612 Add first cut of scaling factor w/30Hz.

Changeset: 03adbb038669439cb1b01335032b5e970d36613f

comment:3 Changed 5 years ago by Mathieu Doucet

Re #11612 Add system test

Changeset: bce0557e08be1c9d86253ff11fa1f60e91d6722a

comment:4 Changed 5 years ago by Mathieu Doucet

Re #11612 Add documentation

Changeset: 3ccc616ba7fd14c8fac8d47a3bca9e53ba0630f8

comment:5 Changed 5 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #626.

comment:6 Changed 5 years ago by Mathieu Doucet

Re #11612 improve fit

Changeset: 806236598112d96f5d6cf01d76be2d944604a907

comment:7 Changed 5 years ago by Mathieu Doucet

Re #11612 add useful logging

Changeset: 427860543747b02aa11f7bbae48e374f408ff143

comment:8 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:9 Changed 5 years ago by Federico Montesino Pouzols

This addresses trac ticket #11612(​http://trac.mantidproject.org/mantid/ticket/11612).

comment:10 Changed 5 years ago by Federico Montesino Pouzols

All looks godd, tests passed (I also run the new system test locally), and the documentation reads well.

comment:11 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #626 from mantidproject/11612_refl_scale

Scaling factor calculation that will work at 30 Hz

Full changeset: ​b09daf7c47b9af6909464c7997534603926f8ffb

comment:12 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.5 to Release 3.4

comment:13 Changed 5 years ago by Mathieu Doucet

Re #11612 Close the file we read from...

Changeset: b6b258303d6cb5f482320a770eac79050d14a880

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12450

Note: See TracTickets for help on using tickets.