Ticket #11613 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Recent changes to headers broke no-precompiled headers windows build

Reported by: Alex Buts Owned by: Alex Buts
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Andrei Savici

Description

Changeset ​https://github.com/mantidproject/mantid/commit/fd5724ef7975ff370851f1c5cd7016bc5e6d9e0b#diff-b84a650c7c83749b36dd3329e4d2d218 removing various headers from kernel have broken windows builds which do not use precompiled headers.

Change History

comment:1 Changed 5 years ago by Alex Buts

  • Status changed from new to inprogress

Re #11613 This should fix the issue by adding missing <functional>

header

Changeset: 936a07119e8bb3310496fce741ad7c63f176f2b7

comment:2 Changed 5 years ago by Andrei Savici

  • Status changed from inprogress to verifying
  • Tester set to Andrei Savici

comment:3 Changed 5 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #625 from mantidproject/11613_BrokenWindowsBuild

fixing windows builds which do not use precompiler headers.

Full changeset: ​e044e2ced64c5b1427f5758b3ed853a0911b1cbf

comment:4 Changed 5 years ago by Nick Draper

  • Resolution set to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:5 Changed 5 years ago by Alex Buts

Merge branch '11613_BrokenWindowsBuild' into 11508_ParamWithHelpString

Full changeset: ​890494643b2ad66f06dcef75f1eda816a683663d

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12451

Note: See TracTickets for help on using tickets.