Ticket #11632 (closed: fixed)
Update poldi.dic for 2015 data
| Reported by: | Michael Wedel | Owned by: | Michael Wedel |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.4 |
| Component: | Diffraction | Keywords: | POLDI |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Federico Montesino Pouzols |
Description
Starting from the 2015 cycle at SINQ, POLDI data will be organized slightly differently.
I would like to get the essential keys into the dictionary so that the data can be processed.
Change History
comment:2 Changed 5 years ago by Michael Wedel
Refs #11632. Old files are the special case now
Changeset: bf3803071de12fe5b02dc8844602326e9697820f
comment:3 Changed 5 years ago by Michael Wedel
Refs #11632. Small adjustment to LoadSINQFile
Changeset: 0a9177e91ec0babf83323b5f1738e58566a40424
comment:4 Changed 5 years ago by Michael Wedel
Refs #11632. Small fix to PoldiMerge
PoldiMerge now skips non-existing log values for comparison but outputs a warning into the log.
Changeset: 32c308a4879a39c4652f4afe37e6742696d005a9
comment:5 Changed 5 years ago by Michael Wedel
Refs #11632. Add system test for loading 2015 data
Changeset: c0d4fa3e5b3b9df962a4f94639611d1e5e7a6312
comment:6 Changed 5 years ago by Michael Wedel
Refs #11632. Fix pylint issue
Changeset: 89de992b7b0621d45c14f8f176dd63fb0366dc11
comment:7 Changed 5 years ago by Michael Wedel
Refs #11632. Remove undecided items from poldi.dic
Changeset: df9ace4d74edc3beb855e16478cb20b47889a49b
comment:8 Changed 5 years ago by Michael Wedel
Refs #11632. Added file for system test.
Changeset: bfcdfa7ddfab395cb2d2d7d20657edca39ed6854
comment:9 Changed 5 years ago by Michael Wedel
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #654.
comment:10 Changed 5 years ago by Michael Wedel
The pylint job reports 13 new problems, but those are in files I did not touch. I suppose that's the "diff" to the last pylint build?
comment:11 Changed 5 years ago by Michael Wedel
Refs #11632. Small change in lookup string method
Changeset: 9335cadf265620be9e0b5d429e4a511a558c426f
comment:12 Changed 5 years ago by Michael Wedel
Refs #11632. Fixing LoadLotsOfFiles test
Changeset: d3be56456d53403cf9b1df934b9467affd5004ea
comment:13 Changed 5 years ago by Michael Wedel
The windows failure seems unrelated, I've scheduled a new build.
comment:14 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verify to verifying
- Tester set to Federico Montesino Pouzols
comment:15 Changed 5 years ago by Federico Montesino Pouzols
This adds an updated NeXus dictionary, and moves the old one to a 'legacy' dict file. All looks fine, LoadLotsOfFiles now includes one POLDI 2015 file, and the relevant tests passed also locally, so let's merge it in just in time...
I was curious about pylint's pickiness. I found one issue in one of the files involved in this branch (PoldiMerge.py), but in a place that has not changed here: http://builds.mantidproject.org/job/pull_requests-pylint/35/violations/file/PoldiMerge.py/ That's a place where it might be good to give a specific expected exception type. I'm amazed. Pylint has an error for 'too few public methods' in a class...
comment:16 Changed 5 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge pull request #654 from mantidproject/11632_update_poldi_dic_for_2015
Enable loading of 2015 POLDI data
Full changeset: 0fa26c71c7123b64af38b2995c56e6eacfa9b24b
comment:17 Changed 5 years ago by Michael Wedel
I will make a ticket for the next release to remove all outstanding pylint issues with the POLDI related code. I particularly like these warnings "too few public methods", "too many private methods" (I think there are more, but I don't recall them now), too.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12470
Refs #11632. Additional dictionary for new POLDI files.
Changeset: 86b22131e20cf8de698e49124979c76ed30a9a09