Ticket #11633 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

IntegrateMDHistoWorkspace should have keep binning + axis limits option

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.4
Component: Framework Keywords: vates
Cc: Blocked By:
Blocking: #11626 Tester: Harry Jeffery

Description

Currently you can set P{n}Bins to be [] or [min,max] where [] means exactly keep the binning and [min,max] means integrate between limits.

Russell Ewings has asked for this to occur as a mode in the LineViewer (11626), but the problem comes when you specify the start and stop within the range of the original data. In this case, you want to keep the existing binning, but you also want to exclude any data between the limits. If you do not do this, it will not be possible to reproduce the slice as drawn in the plots.

I suggest that having a [start, 0, stop] syntax should also be allowed. Only zero's would be accepted and would indicate that the current binning should apply.

Change History

comment:1 Changed 5 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #11633. Allow 3 arg bin option.

Changeset: 5f115d7cf66f67a32efb0e93745ecc7ceed186c3

comment:2 Changed 5 years ago by Owen Arnold

refs #11633. Expand out limits.

Changeset: e380da9cce4861ba588a56d21c3952c305cb0f00

comment:3 Changed 5 years ago by Owen Arnold

refs #11633. Update documentation and doctest.

Changeset: faeaab52c62885cccb0568df0a77ccc03f2c1a4a

comment:4 Changed 5 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #652.

comment:5 Changed 5 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 5 years ago by Owen Arnold

refs #11633. Use floor and ceil.

Should truncate minimum negative values to lower edge. Use std functions to do this.

Changeset: 9339aafd685a669861af7211010732c60562ff0e

comment:7 Changed 5 years ago by Harry Jeffery

Looks good, just waiting on the remaining tests to pass before I merge.

comment:8 Changed 5 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #652 from mantidproject/11633_keep_option

Limits in cut dimension for IntegrateMDHistoWorkspace

Full changeset: ​3c637900cf128f6f119f67f8584eadb8ad39f06d

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12471

Note: See TracTickets for help on using tickets.