Ticket #11638 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Clean (OS)IRIS and IN16B parameter files

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Currently there is a parameter efixed-val attached to the instrument and Efixed attached to the analyser, they are the same values so efixed-val should be removed.

The only time I think it is read is in the IDR ET interface for (OS)IRIS, here Efixed should be read instead.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Use Efixed in UI code

Refs #11638

Changeset: 4840707bcbade9b8990f4c62e2841507472babc7

comment:3 Changed 5 years ago by Dan Nixon

Remove efixed-val from IPFs

Refs #11638

Changeset: ad370843acefff9b0a363988a6b478a210bf51ef

comment:4 Changed 5 years ago by Dan Nixon

Fix remaining use of efixed-val

Refs #11638

Changeset: c0ec6ceca6287ece87886420b6a1f5e506142a67

comment:5 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #658.

comment:6 Changed 5 years ago by Dan Nixon

Fix trivial Python error

Refs #11638

Changeset: cda8566e3fb3d357a2c6ac7eb64465773643abbb

comment:7 Changed 5 years ago by Dan Nixon

Fix failing tests Refs #11638

Changeset: 50e3a4038b1699a1948b1f0718df790d1ef45c83

comment:8 Changed 5 years ago by Dan Nixon

Fix failing system test

Refs #11638

Changeset: 5ca636f3e8fcc6837412f429b08c3de4523616ac

comment:9 Changed 5 years ago by Dan Nixon

Merge branch 'master' into 11638_clean_efixed_parameters

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSqw.cpp

Refs #11638

Changeset: ed5f3e684a4d75644d20a24d8170a0b242c1e5cb

comment:10 Changed 5 years ago by Dan Nixon

  • Milestone changed from Release 3.5 to Release 3.4

comment:11 Changed 5 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 5 years ago by Roman Tolchenov

Which release is it?

comment:13 Changed 5 years ago by Dan Nixon

3.4 now as if it was left to 3.5 this would break UIs as the IPFs would be out of sync with the code.

comment:14 Changed 5 years ago by Dan Nixon

Use Efixed in UI code

Refs #11638

Changeset: 4840707bcbade9b8990f4c62e2841507472babc7

comment:15 Changed 5 years ago by Dan Nixon

Remove efixed-val from IPFs

Refs #11638

Changeset: ad370843acefff9b0a363988a6b478a210bf51ef

comment:16 Changed 5 years ago by Dan Nixon

Fix remaining use of efixed-val

Refs #11638

Changeset: c0ec6ceca6287ece87886420b6a1f5e506142a67

comment:17 Changed 5 years ago by Dan Nixon

Fix trivial Python error

Refs #11638

Changeset: cda8566e3fb3d357a2c6ac7eb64465773643abbb

comment:18 Changed 5 years ago by Dan Nixon

Fix failing tests Refs #11638

Changeset: 50e3a4038b1699a1948b1f0718df790d1ef45c83

comment:19 Changed 5 years ago by Dan Nixon

Fix failing system test

Refs #11638

Changeset: 5ca636f3e8fcc6837412f429b08c3de4523616ac

comment:20 Changed 5 years ago by Dan Nixon

Merge branch 'master' into 11638_clean_efixed_parameters

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSqw.cpp

Refs #11638

Changeset: ed5f3e684a4d75644d20a24d8170a0b242c1e5cb

comment:21 Changed 5 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #658 from mantidproject/11638_clean_efixed_parameters

Clean efixed parameters in indirect IPFs

Full changeset: ​5e3ce448daa55201a8b7d3aafd3612872c64248f

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12476

Note: See TracTickets for help on using tickets.