Ticket #11651 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Allow PlotPeakByLogValue to take a minimizer string

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #11561 Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

Allow this to accept a string like Fit to configure a minimizer with options (e.g. FABADA).

Also add a MaxIterations property with the value passed directly to Fit.

There will be the option to make the minimizer string templated to include workspace information (i.e. name and spectrum index) so that output is not overwritten on minimizers such as FABADA that output workspaces.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to inprogress

Modify minimizer property and add max iterations

Refs #11651

Changeset: 85ae97ba9f43ba94083d11b95c9e34dd0778444f

comment:2 Changed 5 years ago by Dan Nixon

  • Blocking 11561 added

comment:3 Changed 5 years ago by Dan Nixon

Test new properties Refs #11651

Changeset: 753b1e7faad8fe0e178121a2a7839357bd881227

comment:4 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #672.

comment:5 Changed 5 years ago by Dan Nixon

Fix failing builds Refs #11651

Changeset: 754a8758e9e1a361421c2f1d97de884ef9eba9c7

comment:6 Changed 5 years ago by Dan Nixon

Add flags for workspace and spec names in minimizer string

Refs #11651

Changeset: 35f2a686a98b410f0bbfd5dbd6c1f0f38e4c2dd0

comment:7 Changed 5 years ago by Dan Nixon

Group the output workspaces

Refs #11651

Changeset: 73794ae2c33a2911f6b1389be1993f4fcf443420

comment:8 Changed 5 years ago by Dan Nixon

Clang format Refs #11651

Changeset: ed5a4c3f170db24e74fa97c8c70ea48d37c5ad73

comment:9 Changed 5 years ago by Dan Nixon

  • Description modified (diff)

comment:10 Changed 5 years ago by Dan Nixon

Document options for minimizer string

Refs #11651

Changeset: 9e5f0f8dd5eb6d16f894d3f3bd5251a664b5b1e9

comment:11 Changed 5 years ago by Dan Nixon

Test the minimizer string option

Refs #11651

Changeset: d8dc0e5951c919e9cd23ef1bb4f2479c0fd24a39

comment:12 Changed 5 years ago by Dan Nixon

Ignore empty workspace names

Refs #11651

Changeset: a3b282b0b1a0949aadadd18a476914ae29fb9d19

comment:13 Changed 5 years ago by Dan Nixon

Also allow the output workspace to be used

Refs #11651

Changeset: 065f6496f746170fa2ebcf1b70d29e6effc27803

comment:14 Changed 5 years ago by Dan Nixon

Merge branch '11651_plotpeakbylogvalue_minimizer_string' into 11561_convfit_furyfit_fabada

Refs #11651

Changeset: 6914328a071a67ed7e4abbcfe2fff08d0d803f9e

comment:15 Changed 5 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:16 Changed 5 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #672 from mantidproject/11651_plotpeakbylogvalue_minimizer_string

Allow PlotPeakByLogValue to accept a minimizer string

Full changeset: ​1ba6ced5e772eaa55bc144230cd2183b9e83adcf

comment:17 Changed 5 years ago by Dan Nixon

Merge branch '11651_plotpeakbylogvalue_minimizer_string' into 11561_convfit_furyfit_fabada

Refs #11561

Full changeset: ​2431adfe7470cbab459c00493644b4369c2607e9

comment:18 Changed 5 years ago by Dan Nixon

Merge branch '11651_plotpeakbylogvalue_minimizer_string' into 11561_convfit_furyfit_fabada

Refs #11651

Full changeset: ​6914328a071a67ed7e4abbcfe2fff08d0d803f9e

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12489

Note: See TracTickets for help on using tickets.