Ticket #11654 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Respect qmin/qmax on new Reflectometry UI

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.5
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Open the new reflectometry UI:

Add a single row

  • run: 13460
  • Angle: 0.7
  • qmin: 0.01
  • qmax: 0.06
  • dqq: 0.04

Set instrument to INTER and hit process. If you look at the resulting IvQ workspace, you'll find that x goes outside the qmin/qmax range. This should not happen.

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:2 Changed 5 years ago by Harry Jeffery

Refs #11654 Respect qmin and qmax in new Refl UI

Changeset: 9813772d5d754211c0c305660c57f809f6c3a588

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11654 Handle edge cases

If only qmin, or qmax is provided but the other isn't, we want to handle that correctly. Moving this logic out of the else clause does that.

Changeset: e152e7b96fd63cb06d46795020075b771de79f3d

comment:4 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #679.

comment:5 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:6 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #679 from mantidproject/11654_respect_qmin_qmax_in_new_refl_ui

Respect qmin & qmax limits in new Reflectometry UI

Full changeset: ​b70386f0f8381bef6dd65574edfb9459b086c58f

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12492

Note: See TracTickets for help on using tickets.